GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145056: Fix merging of OrderedDict and UserDict with frozendict by serhiy-storchaka · Pull Request #146295 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Mar 22, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is based on #145060, but with added tests, and fixed OrderedDict | frozendict for the C implementation.

But frozendict | OrderedDict still returns wrong type.

  • Issue: Many pure python tools that have a special cases for dict should accept frozendict as well. #145056

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
rhettinger and others added 5 commits February 20, 2026 18:10
@rhettinger
pythongh-145056: Let dict specific tests accept frozendict as well
f27f128
@rhettinger
Add tests
4d02992
@rhettinger
Expand the fast path in the C version of OrderedDict
a887273
@serhiy-storchaka
Merge branch 'main' into collections_any_dict
f66f9a1
@serhiy-storchaka
Add tests and fix OrderedDict | frozendict.
5f32ed5
@serhiy-storchaka
serhiy-storchaka requested a review from rhettinger March 22, 2026 15:25
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 22, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 22, 2026
Many pure python tools that have a special cases for dict should accept frozendict as well. #145056
Open
@serhiy-storchaka

serhiy-storchaka commented Mar 26, 2026

Copy link
Copy Markdown
Member Author

Split on separate PRs:

  • gh-145056: Add support for merging collections.UserDict and frozendict #146465
  • gh-145056: Fix merging of collections.OrderedDict and frozendict #146466
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka serhiy-storchaka closed this Mar 26, 2026
@serhiy-storchaka
serhiy-storchaka deleted the collections_any_dict branch March 26, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @rhettinger
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.