GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145056: Fix merging of collections.OrderedDict and frozendict by serhiy-storchaka · Pull Request #146466 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Mar 26, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Many pure python tools that have a special cases for dict should accept frozendict as well. #145056

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
serhiy-storchaka requested a review from rhettinger March 26, 2026 13:00
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 26, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 26, 2026
Many pure python tools that have a special cases for dict should accept frozendict as well. #145056
Open
@serhiy-storchaka
serhiy-storchaka force-pushed the merge-op-ordereddict-frozendict branch from 0c8cbb0 to 931ae5f Compare March 26, 2026 13:01
@serhiy-storchaka serhiy-storchaka mentioned this pull request Mar 26, 2026
gh-145056: Fix merging of OrderedDict and UserDict with frozendict #146295
Closed
@serhiy-storchaka

serhiy-storchaka commented Mar 26, 2026

Copy link
Copy Markdown
Member Author

This only fixes the case OrderedDict() | frozendict(). The case frozendict() | OrderedDict() is more complex, it will require changes in frozendict. And that issue will be related to frozenset too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka force-pushed the merge-op-ordereddict-frozendict branch from 931ae5f to 0a9b814 Compare March 26, 2026 13:11
@serhiy-storchaka
pythongh-145056: Fix merging of collections.OrderedDict and frozendict
01a5ae5
@serhiy-storchaka
serhiy-storchaka force-pushed the merge-op-ordereddict-frozendict branch from 0a9b814 to 01a5ae5 Compare March 26, 2026 13:13
vstinner
vstinner approved these changes Mar 27, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 27, 2026
@serhiy-storchaka
serhiy-storchaka merged commit 7278904 into python:main Mar 30, 2026
96 of 98 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 30, 2026
@serhiy-storchaka
serhiy-storchaka deleted the merge-op-ordereddict-frozendict branch March 30, 2026 19:06
maurycy added a commit to maurycy/cpython that referenced this pull request Mar 31, 2026
@maurycy
Merge branch 'main' into tachyon-ndjson-kolektor
9836ffa 
* main:
  pythongh-145458: use `self.skip_idle` consistently in the tachyon profiler (python#145459)
  pythongh-146615: Fix format specifiers in Objects/ directory (pythonGH-146620)
  pythongh-146615: Fix format specifiers in Python/ directory (pythonGH-146619)
  pythongh-146615: Fix format specifiers in test cextensions (pythonGH-146618)
  pythongh-146615: Fix format specifiers in extension modules (pythonGH-146617)
  pythongh-146615: Fix crash in __get__() for METH_METHOD descriptors with invalid type argument (pythonGH-146634)
  pythongh-146376: Reduce timeout in Emscripten GHA workflow (python#146378)
  pythongh-146442: Fix various bugs in compiler pipeline (python#146443)
  pythongh-146238: Support half-floats in the array module (python#146242)
  pythongh-145056: Add support for merging collections.UserDict and frozendict (pythonGH-146465)
  pythongh-145056: Fix merging of collections.OrderedDict and frozendict (pythonGH-146466)
  pythongh-139633: Run netrc file permission check only once per parse (pythonGH-139634)
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@serhiy-storchaka @clin1234
pythongh-145056: Fix merging of collections.OrderedDict and frozendict (
129f815 
pythonGH-146466)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@serhiy-storchaka @ljfp
pythongh-145056: Fix merging of collections.OrderedDict and frozendict (
5613cbd 
pythonGH-146466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.