GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146261: JIT: protect against function version changes by Fidget-Spinner · Pull Request #146300 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Mar 22, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR reverts the func_version symbol changes by using the fact that we have recorded values and _CHECK_FUNCTION_VERSION guards --- if we simply keep those around and not eliminate them, our function versions are guaranteed to be correct for all following _PUSH_FRAME if we invalidate dependencies properly in the function version changes.

  • Issue: JIT: Optimization in _CHECK_FUNCTION_VERSION is wrong #146261

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
JIT: protect against function version changes
a1ef342
@Fidget-Spinner
Fidget-Spinner requested review from markshannon, savannahostrowski and tomasr8 as code owners March 22, 2026 16:54
@bedevere-app bedevere-app Bot mentioned this pull request Mar 22, 2026
JIT: Optimization in _CHECK_FUNCTION_VERSION is wrong #146261
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 22, 2026
@Fidget-Spinner Fidget-Spinner added skip news awaiting core review and removed awaiting core review labels Mar 22, 2026
@Fidget-Spinner
pass the interp
dc19d93
kumaraditya303
kumaraditya303 reviewed Apr 6, 2026
View reviewed changes
Comment thread Objects/funcobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Apr 6, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 6, 2026
@Fidget-Spinner @kumaraditya303
Update Objects/funcobject.c
463ed28 
Co-authored-by: Kumar Aditya <[email protected]>
@Sacul0457 Sacul0457 mentioned this pull request Apr 9, 2026
gh-131798: Split CHECK_FUNCTION_VERSION into two guards in the JIT #145080
Open
@Fidget-Spinner

Fidget-Spinner commented Apr 9, 2026

Copy link
Copy Markdown
Member Author

@markshannon does this bugfix look okay to you? The reason we need this is that __code__ can be swapped out for functions. If you think it's okay, I can merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner added 4 commits April 13, 2026 01:01
@Fidget-Spinner
Merge remote-tracking branch 'upstream/main' into fix_func_version_ch…
ff29164 
…anges
@Fidget-Spinner
remove func version symbol altogether --- to buggy without watchers
9dd70a0
@Fidget-Spinner
Fixups
8806c74
@Fidget-Spinner
Add back test properly
6a42001
@NekoAsakura NekoAsakura mentioned this pull request Apr 12, 2026
gh-148438: implement _RECORD_BOUND_METHOD in JIT #148457
Merged
@Fidget-Spinner
Fidget-Spinner merged commit 6f7bb29 into python:main Apr 12, 2026
69 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 12, 2026
prakashsellathurai added a commit to prakashsellathurai/cpython that referenced this pull request Apr 13, 2026
@prakashsellathurai
Revert "pythongh-146261: JIT: protect against function version changes (
54f801c 
python#146300)"

This reverts commit 6f7bb29.
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@Fidget-Spinner @kumaraditya303 @ljfp
pythongh-146261: JIT: protect against function version changes (pytho…
2fc06a4 
…n#146300)

Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Fidget-Spinner @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.