GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-146210: Fix building the jit stencils on Windows when the interpreter is built with a different clang version by chris-eibl · Pull Request #146338 · python/cpython

Conversation

@chris-eibl

@chris-eibl chris-eibl commented Mar 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

By dropping the environment variable INCLUDE when building the jit stencils. Since this is Windows specific, this is only done on Windows.

  • Issue: LLVM 22 clang-cl on Windows fails for jit builds #146210

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chris-eibl
fix building the jit stencils on Windows when the
390cc8a 
interpreter is built with a different clang version.
@chris-eibl
chris-eibl requested review from brandtbucher, diegorusso and savannahostrowski as code owners March 23, 2026 19:16
@bedevere-app bedevere-app Bot mentioned this pull request Mar 23, 2026
LLVM 22 clang-cl on Windows fails for jit builds #146210
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Mar 23, 2026
savannahostrowski
savannahostrowski requested changes Apr 3, 2026
View reviewed changes

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at this!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tools/jit/_llvm.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/jit/_llvm.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Apr 3, 2026
@bedevere-app

bedevere-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting changes label Apr 3, 2026
chris-eibl and others added 3 commits April 3, 2026 18:02
@chris-eibl @savannahostrowski
Use Savannah's much better and shorter description
1a08565 
Co-authored-by: Savannah Ostrowski <[email protected]>
@chris-eibl
Merge branch 'main' into gh146210
48eb2ea
@chris-eibl
env.pop("INCLUDE", None)
3c00136
savannahostrowski
savannahostrowski approved these changes Apr 3, 2026
View reviewed changes

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
chris-eibl reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting changes labels Apr 3, 2026
@savannahostrowski
Merge branch 'main' into gh146210
443bb06
@savannahostrowski
savannahostrowski merged commit dea4083 into python:main Apr 3, 2026
78 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 3, 2026
@chris-eibl
chris-eibl deleted the gh146210 branch April 3, 2026 19:43
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@chris-eibl @savannahostrowski @ljfp
pythonGH-146210: Fix building the jit stencils on Windows when the in…
443237d 
…terpreter is built with a different clang version (python#146338)

Co-authored-by: Savannah Ostrowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowski savannahostrowski savannahostrowski approved these changes
@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner
@diegorusso diegorusso Awaiting requested review from diegorusso diegorusso is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@chris-eibl @savannahostrowski
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.