GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-143930: Reject leading dashes in webbrowser URLs by Pinky-Chaudhary · Pull Request #146360 · python/cpython

Conversation

@Pinky-Chaudhary

@Pinky-Chaudhary Pinky-Chaudhary commented Mar 24, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

(cherry picked from commit 82a24a4)

  • Issue: Reject leading dashes in webbrowser.open() #143930

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
fslds reacted with eyes emoji
All reactions
  • 👀 1 reaction
@sethmlarson Pinky Chaudhary
pythongh-143930: Reject leading dashes in webbrowser URLs
d498b7e 
(cherry picked from commit 82a24a4)
@bedevere-app bedevere-app Bot mentioned this pull request Mar 24, 2026
Reject leading dashes in webbrowser.open() #143930
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Mar 24, 2026
@Pinky-Chaudhary Pinky-Chaudhary changed the title gh-143930: Reject leading dashes in webbrowser URLs [3.12] gh-143930: Reject leading dashes in webbrowser URLs Mar 24, 2026
ambv
ambv requested changes Mar 24, 2026
View reviewed changes

@ambv ambv left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backport needs to be equivalent to what was landed in 3.13 - 3.15. Don't make any other changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot removed the awaiting review label Mar 24, 2026
@bedevere-app

bedevere-app Bot commented Mar 24, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting changes label Mar 24, 2026
@Pinky-Chaudhary
Simplify error message for invalid URL- backport
1155efb
@python-cla-bot

python-cla-bot Bot commented Mar 24, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Pinky-Chaudhary

Pinky-Chaudhary commented Mar 24, 2026

Copy link
Copy Markdown
Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels Mar 24, 2026
@bedevere-app

bedevere-app Bot commented Mar 24, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@ambv: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app
bedevere-app Bot requested a review from ambv March 24, 2026 18:33
ambv
ambv approved these changes Mar 24, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting change review labels Mar 24, 2026
@ambv
ambv merged commit cbba611 into python:3.12 Mar 24, 2026
29 of 32 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 24, 2026
@ambv

ambv commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Thanks, @Pinky-Chaudhary!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Pinky-Chaudhary
Pinky-Chaudhary deleted the backport-82a24a4-3.12 branch March 25, 2026 05:06
hroncok pushed a commit to fedora-python/cpython that referenced this pull request Mar 26, 2026
@Pinky-Chaudhary @sethmlarson @hroncok
00478: CVE-2026-4519
196302b 
Reject leading dashes in webbrowser URLs (pythonGH-146360)

(cherry picked from commit 82a24a4)

Co-authored-by: Seth Michael Larson <[email protected]>
stratakis pushed a commit to stratakis/cpython that referenced this pull request Apr 16, 2026
@Pinky-Chaudhary @sethmlarson @stratakis
00478: CVE-2026-4519
e51fc65 
Reject leading dashes in webbrowser URLs (pythonGH-146360)

(cherry picked from commit 82a24a4)

Co-authored-by: Seth Michael Larson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Pinky-Chaudhary @ambv @sethmlarson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.