GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146386:`modsupport.c` Missing `va_end` in `_abiinfo_raise` by A0su · Pull Request #146387 · python/cpython

Conversation

@A0su

@A0su A0su commented Mar 24, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

modsupport.c: Missing va_end in _abiinfo_raise

va_start(vargs, format) at line 689 but va_end(vargs) never called on any path. UB per C99 7.15.1.

This is a sub-issue of #146102 with original gist details

va_end was added at the two exit points.

  • Issue: modsupport.c: Missing va_end in _abiinfo_raise #146386

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@A0su
add missing var_end calls at exit points
2999783
@A0su
A0su requested a review from ericsnowcurrently as a code owner March 24, 2026 18:11
@bedevere-app

bedevere-app Bot commented Mar 24, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Mar 24, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 24, 2026
modsupport.c: Missing va_end in _abiinfo_raise #146386
Closed
kumaraditya303
kumaraditya303 approved these changes Mar 25, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 25, 2026
@kumaraditya303 kumaraditya303 added the skip news label Mar 25, 2026
@kumaraditya303
kumaraditya303 merged commit 04bd543 into python:main Mar 25, 2026
57 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 25, 2026
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@A0su @clin1234
pythongh-146386: fix missing va_end in _abiinfo_raise in `modsupp…
3dcffa3 
…ort.c` (python#146387)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@A0su @ljfp
pythongh-146386: fix missing va_end in _abiinfo_raise in `modsupp…
800514c 
…ort.c` (python#146387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@A0su @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.