GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-138573: filter out failing math tests on Solaris by skirpichev · Pull Request #146402 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Mar 25, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: test.test_math.MathTests.testAtan2 failure on OpenIndiana/Solaris #138573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skirpichev
pythongh-138573: filter out failing math tests on Solaris
210688d
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Mar 25, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 25, 2026
test.test_math.MathTests.testAtan2 failure on OpenIndiana/Solaris #138573
Closed
@skirpichev skirpichev added the skip news label Mar 25, 2026
@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label Mar 25, 2026
@vstinner

vstinner commented Mar 25, 2026

Copy link
Copy Markdown
Member

I can see the test_math.testAtan2() and test_cmath.test_phase() failures on the Solaris buildbot: https://buildbot.python.org/#/builders/742/builds/9890

ERROR: testAtan2 (test.test_math.MathTests.testAtan2)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/share/buildbot-worker/python/3.x.kulikjak-solaris-sparcv9/build/Lib/test/test_math.py", line 306, in testAtan2
    self.ftest('atan2(0., -0.)', math.atan2(0., -0.), math.pi)
                                 ~~~~~~~~~~^^^^^^^^^
ValueError: math domain error

and

ERROR: test_phase (test.test_cmath.CMathTests.test_phase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/share/buildbot-worker/python/3.x.kulikjak-solaris-sparcv9/build/Lib/test/test_cmath.py", line 410, in test_phase
    self.assertAlmostEqual(phase(0), 0.)
                           ~~~~~^^^
ValueError: math domain error
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 25, 2026

Copy link
Copy Markdown
Member

There are the two same errors on the 3.14 Solaris buildbot: https://buildbot.python.org/#/builders/1804/builds/808. So we can backport this change to 3.14.

On the 3.13 Solaris buildbot, test_math and test_cmath pass, so there is no need to backport to 3.13.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 8e1469c into python:main Mar 25, 2026
54 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Mar 25, 2026

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Mar 25, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2026
@skirpichev @miss-islington
pythongh-138573: Filter out failing math tests on Solaris (pythonGH-1…
466ff99 
…46402)

(cherry picked from commit 8e1469c)

Co-authored-by: Sergey B Kirpichev <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 25, 2026

Copy link
Copy Markdown

GH-146438 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 25, 2026
@skirpichev
skirpichev deleted the filter-math-tests-on-sunos/138573 branch March 25, 2026 23:13
vstinner pushed a commit that referenced this pull request Mar 26, 2026
@miss-islington @skirpichev
[3.14] gh-138573: Filter out failing math tests on Solaris (GH-146402) (
7efa72a 
#146438)

gh-138573: Filter out failing math tests on Solaris (GH-146402)
(cherry picked from commit 8e1469c)

Co-authored-by: Sergey B Kirpichev <[email protected]>
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@skirpichev @clin1234
pythongh-138573: Filter out failing math tests on Solaris (python#146402
3989081 
)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@skirpichev @ljfp
pythongh-138573: Filter out failing math tests on Solaris (python#146402
7cd988b 
)
@hpkfft hpkfft mentioned this pull request Jul 6, 2026
gh-153144: Avoid checking errno for atan2 #153148
Open
hpkfft added a commit to hpkfft/cpython that referenced this pull request Aug 14, 2026
@hpkfft
Revert pythongh-146402 and update NEWS entry
43f7398 
This reverts commit 8e1469c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@skirpichev @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.