GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-146431: Add the wrapcol and ignorechars parameters for more Base XX codec by serhiy-storchaka · Pull Request #146434 · python/cpython

Conversation

serhiy-storchaka commented Mar 25, 2026 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Add the wrapcol parameter to base64 functions b16encode(), b32encode(), b32hexencode(), b85encode() and z85encode(), and binascii functions b2a_base32() and b2a_base85().

Add the ignorechars parameter to base64 functions b16decode(), b32decode(), b32hexdecode(), b85decode() and z85decode(), and binascii functions a2b_hex(), unhexlify(), a2b_base32() and a2b_base85().

Issue: Add wrapcol and ignorechars parameters for other Base XX codecs #146431

📚 Documentation preview 📚: https://cpython-previews--146434.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka requested a review from gpshead

March 25, 2026 19:15

serhiy-storchaka requested a review from AA-Turner as a code owner

March 25, 2026 19:15

bedevere-app Bot mentioned this pull request

Mar 25, 2026

Add wrapcol and ignorechars parameters for other Base XX codecs #146431

Closed

bedevere-app Bot added the awaiting core review label

Mar 25, 2026


          pythongh-146431: Add the wrapcol and ignorechars parameters for more …

c88fb7a

…Base XX codec

Add the wrapcol parameter to base64 functions b16encode(), b32encode(),
b32hexencode(), b85encode() and z85encode(), and binascii functions
b2a_base32() and b2a_base85().

Add the ignorechars parameter to base64 functions b16decode(), b32decode(),
b32hexdecode(), b85decode() and z85decode(), and binascii functions
a2b_hex(), unhexlify(), a2b_base32() and a2b_base85().

serhiy-storchaka force-pushed the basexx-wrapcol-ignorechars branch from ea2c65d to c88fb7a Compare

March 25, 2026 21:13

gpshead reviewed

Mar 31, 2026

View reviewed changes

gpshead left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

food for thought: could wrapcol be limited to "even" columns of one decodable chunk? (at least for base16/32/64) - It makes little sense to wrap on unusual boundaries.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/base64.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/base64.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/base64.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/binascii.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/binascii.c

		int group_pos = 0;
		for (; ascii_len > 0 \|\| group_pos != 0; ascii_len--, ascii_data++) {
		/* Shift (in radix-85) data or padding into our buffer. */
		unsigned char this_ch;

gpshead Mar 31, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	unsigned char this_ch;
	unsigned char this_ch = 0;

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka Apr 1, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is always initialized before use.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/base64.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Apply suggestions from code review

7e6dcb6

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>

serhiy-storchaka commented

Mar 31, 2026

View reviewed changes

Comment thread

Lib/test/test_base64.py

		if check_impl_detail():
		eq(base64.b64encode(b, wrapcol=sys.maxsize*2),
		b'd3d3LnB5dGhvbi5vcmc=')
		if func is not base64.b16encode:

serhiy-storchaka Mar 31, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#147944 will allow to remove some of these special cases.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead reacted with thumbs up emoji

All reactions

👍 1 reaction

serhiy-storchaka commented Mar 31, 2026

Copy link

Copy Markdown

Member Author

food for thought: could wrapcol be limited to "even" columns of one decodable chunk? (at least for base16/32/64) - It makes little sense to wrap on unusual boundaries.

It is limited to the multiple of the size of the group: 2 for base16, 8 for base32, 4 for base64, 5 for base85. Ascii85 has no restriction, because some groups are encoded as one character.

gpshead reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead approved these changes

Mar 31, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Mar 31, 2026

serhiy-storchaka merged commit 42825e6 into python:main

Apr 1, 2026

57 checks passed

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Apr 1, 2026

serhiy-storchaka deleted the basexx-wrapcol-ignorechars branch

April 1, 2026 07:48

pablogsal mentioned this pull request

Apr 4, 2026

gh-130273: Fix traceback color output with unicode characters #142529

Merged

clin1234 pushed a commit to clin1234/cpython that referenced this pull request

Apr 16, 2026


          pythongh-146431: Add the wrapcol and ignorechars parameters for more …

34046fb

…Base XX codec (pythonGH-146434)

Add the wrapcol parameter to base64 functions b16encode(), b32encode(),
b32hexencode(), b85encode() and z85encode(), and binascii functions
b2a_base32() and b2a_base85().

Add the ignorechars parameter to base64 functions b16decode(), b32decode(),
b32hexdecode(), b85decode() and z85decode(), and binascii functions
a2b_hex(), unhexlify(), a2b_base32() and a2b_base85().

ljfp pushed a commit to ljfp/cpython that referenced this pull request

Apr 25, 2026


          pythongh-146431: Add the wrapcol and ignorechars parameters for more …

c969fc0

…Base XX codec (pythonGH-146434)

Add the wrapcol parameter to base64 functions b16encode(), b32encode(),
b32hexencode(), b85encode() and z85encode(), and binascii functions
b2a_base32() and b2a_base85().

Add the ignorechars parameter to base64 functions b16decode(), b32decode(),
b32hexdecode(), b85decode() and z85decode(), and binascii functions
a2b_hex(), unhexlify(), a2b_base32() and a2b_base85().

Reviewers

gpshead

gpshead approved these changes

AA-Turner

Awaiting requested review from AA-Turner

AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Mar 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gpshead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gpshead Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

serhiy-storchaka Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

serhiy-storchaka commented Mar 25, 2026 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.