GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-GH-131798: optimize jit attribute loads on immutable types by kumaraditya303 · Pull Request #146449 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Mar 26, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Better uop coverage in the JIT optimizer #131798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot mentioned this pull request Mar 26, 2026
Better uop coverage in the JIT optimizer #131798
Open
@kumaraditya303
optimize jit attribute loads on immutable types
4b401a7
@kumaraditya303
kumaraditya303 force-pushed the jit branch from 75500b1 to 4b401a7 Compare March 26, 2026 06:26
@kumaraditya303 kumaraditya303 changed the title gh-GH-131798: do not add type watchers for immutable types gh-GH-131798: optimize jit attribute loads on immutable types Mar 26, 2026
kumaraditya303 added 3 commits March 26, 2026 14:38
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into jit
ad15c8d
@kumaraditya303
add comment
65cae76
@kumaraditya303
improve test
8f860c9
@kumaraditya303 kumaraditya303 added the skip news label Mar 26, 2026
@kumaraditya303
kumaraditya303 marked this pull request as ready for review March 26, 2026 09:19
@kumaraditya303
kumaraditya303 requested review from Fidget-Spinner, markshannon, savannahostrowski and tomasr8 as code owners March 26, 2026 09:19
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 26, 2026
Fidget-Spinner
Fidget-Spinner approved these changes Mar 26, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 26, 2026
@Fidget-Spinner

Fidget-Spinner commented Mar 26, 2026

Copy link
Copy Markdown
Member

It seems list.append is now folded, so you need to change the test test_call_list_append to fix it. That's a great result!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
fix test_call_list_append
92658e4
@kumaraditya303

kumaraditya303 commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

It seems list.append is now folded, so you need to change the test test_call_list_append to fix it. That's a great result!

Thanks, done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner
Fidget-Spinner approved these changes Mar 26, 2026
View reviewed changes
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) March 26, 2026 09:44
@kumaraditya303
kumaraditya303 merged commit fc1f6b1 into python:main Mar 26, 2026
67 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 26, 2026
@kumaraditya303
kumaraditya303 deleted the jit branch March 26, 2026 10:12
@kumaraditya303 kumaraditya303 added the topic-JIT label Mar 31, 2026
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@kumaraditya303 @clin1234
gh-pythonGH-131798: optimize jit attribute loads on immutable types (p…
a1b5f1d 
…ython#146449)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@kumaraditya303 @ljfp
gh-pythonGH-131798: optimize jit attribute loads on immutable types (p…
0b24788 
…ython#146449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kumaraditya303 @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.