GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-146444: Move the Apple folder to the Platforms directory by freakboy3742 · Pull Request #146497 · python/cpython

Conversation

freakboy3742 commented Mar 26, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Part of the broader migration of platform build scripts into the Platforms folder.

Does a complete move - there's no compatibility shim for the old script location. Given the script is only used by CPython's build system, it didn't seems necessary; happy to revisit that if people think otherwise.

The iOS folder hasn't been deleted (yet); it needs to be retained until the buildbot configuration can be switched over to use the Platforms build script (see python/buildmaster-config#691). Once the buildbot has been updated, we can delete the iOS folder as a follow up PR.

Issue: Move Apple folder into Platforms #146444

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

freakboy3742 added 2 commits

March 27, 2026 06:04


          Migrate the Apple folder to the Platforms directory.

5c90880


          Add blurb.

d54f9df

freakboy3742 requested a review from ned-deily

March 26, 2026 22:18

freakboy3742 requested review from AA-Turner, corona10, emmatyping, erlend-aasland, ezio-melotti, hugovk and webknjaz as code owners

March 26, 2026 22:18

bedevere-app Bot added the awaiting core review label

Mar 26, 2026

bedevere-app Bot mentioned this pull request

Mar 26, 2026

Move Apple folder into Platforms #146444

Closed

freakboy3742 commented Mar 26, 2026

Copy link

Copy Markdown

Contributor Author

!buildbot iOS

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Mar 26, 2026

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit d54f9df 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146497%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

iOS ARM64 Simulator PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brianschubert commented Mar 26, 2026

Copy link

Copy Markdown

Contributor

re: the pre-commit errors, you'll need to update the ruff hooks for the Apple/ directory in .pre-commit-config.yaml:

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index dfd18182105..ffff35fc7fe 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -5,7 +5,7 @@ repos:
       - id: ruff-check
         name: Run Ruff (lint) on Apple/
         args: [--exit-non-zero-on-fix, --config=Apple/.ruff.toml]
-        files: ^Apple/
+        files: ^Platforms/Apple/
       - id: ruff-check
         name: Run Ruff (lint) on Doc/
         args: [--exit-non-zero-on-fix]
@@ -41,7 +41,7 @@ repos:
       - id: ruff-format
         name: Run Ruff (format) on Apple/
         args: [--exit-non-zero-on-fix, --config=Apple/.ruff.toml]
-        files: ^Apple
+        files: ^Platforms/Apple
       - id: ruff-format
         name: Run Ruff (format) on Doc/
         args: [--exit-non-zero-on-fix]

freakboy3742 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

freakboy3742 added 2 commits

March 27, 2026 08:12


          Tweak pre-commit config for new location.

68ab7e4


          Fix a linting problem.

d8f61f8

ned-deily approved these changes

Mar 27, 2026

View reviewed changes

ned-deily left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I ran my standard test build of all three iOS architectures without errors, having first removed the legacy ./iOS directory just to be sure. I also then ran the testios Makefile step for the arm64-apple-ios-simulator architecture with no test suite errors. The build and simulator run was on macOS 26.4 using an older Xcode 16.4 16F6 with its default SDKs.

FWIW, I was unable to build the arm64-apple-ios-simulator arch using the just-released Xcode 26.4 17E192; it failed with errors in posixmodule.c, no doubt unrelated to the changes in this PR. The build of arm64-apple-ios succeeded.

../Modules/posixmodule.c:11833:15: error: call to undeclared function 'dup3'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
 11833 |         res = dup3(fd, fd2, O_CLOEXEC);
       |               ^
../Modules/posixmodule.c:12701:11: error: call to undeclared function 'pipe2'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
 12701 |     res = pipe2(fds, O_CLOEXEC);
       |           ^
../Modules/posixmodule.c:12701:11: note: did you mean 'pipe'?
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator26.4.sdk/usr/include/unistd.h:482:6: note: 'pipe' declared here
  482 | int      pipe(int [2]);
      |          ^
../Modules/posixmodule.c:12758:11: error: call to undeclared function 'pipe2'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
 12758 |     res = pipe2(fds, flags);
       |           ^

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Mar 27, 2026

freakboy3742 added the DO-NOT-MERGE label

Mar 27, 2026

freakboy3742 commented Mar 27, 2026

Copy link

Copy Markdown

Contributor Author

FWIW, I was unable to build the arm64-apple-ios-simulator arch using the just-released Xcode 26.4 17E192; it failed with errors in posixmodule.c, no doubt unrelated to the changes in this PR. The build of arm64-apple-ios succeeded.

Well that's fun... something for me to investigate (although I need to upgrade to macOS 26 first... currently stuck in limbo waiting for a possible laptop upgrade).

I've marked this DO NOT MERGE temporarily; it will be easier to backport if #146499 lands first.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

freakboy3742 removed the DO-NOT-MERGE label

Mar 27, 2026


          Merge branch 'main' into apple-platforms

fb2ea07

freakboy3742 enabled auto-merge (squash)

March 27, 2026 02:28

freakboy3742 mentioned this pull request

Mar 27, 2026

Update buildbot to use XCframework build script. python/buildmaster-config#691

Merged

freakboy3742 merged commit 36e4ffc into python:main

Mar 27, 2026

52 checks passed

Uh oh!

There was an error while loading. Please reload this page.

freakboy3742 deleted the apple-platforms branch

March 27, 2026 02:50

bedevere-app Bot removed the awaiting merge label

Mar 27, 2026

pablogsal mentioned this pull request

Apr 4, 2026

gh-130273: Fix traceback color output with unicode characters #142529

Merged

clin1234 pushed a commit to clin1234/cpython that referenced this pull request

Apr 16, 2026


          pythongh-146444: Move the Apple folder to the Platforms directory (py…

f55458f

…thon#146497)

Migrate the Apple/iOS XCframework build tools to the Platforms directory.

ljfp pushed a commit to ljfp/cpython that referenced this pull request

Apr 25, 2026


          pythongh-146444: Move the Apple folder to the Platforms directory (py…

47e9806

…thon#146497)

Migrate the Apple/iOS XCframework build tools to the Platforms directory.

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request

Jun 12, 2026


          [3.14] pythongh-146444: Move the Apple folder to the Platforms direct…

…ory (python#146497)

Migrate the Apple/iOS XCframework build tools to the Platforms directory.

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request

Jun 12, 2026


          [3.14] pythongh-146444: Move the Apple folder to the Platforms direct…

b2f091f

…ory (python#146497)

Migrate the Apple/iOS XCframework build tools to the Platforms directory.

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request

Oct 2, 2026


          [3.14] pythongh-146444: Move the Apple folder to the Platforms direct…

850fe4c

…ory (python#146497)

Migrate the Apple/iOS XCframework build tools to the Platforms directory.

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request

Oct 12, 2026


          [3.14] pythongh-146444: Move the Apple folder to the Platforms direct…

275a9db

…ory (python#146497)

Migrate the Apple/iOS XCframework build tools to the Platforms directory.

Reviewers

ned-deily

ned-deily approved these changes

erlend-aasland

Awaiting requested review from erlend-aasland

erlend-aasland is a code owner

AA-Turner

Awaiting requested review from AA-Turner

AA-Turner is a code owner

emmatyping

Awaiting requested review from emmatyping

emmatyping is a code owner

corona10

Awaiting requested review from corona10

corona10 is a code owner

ezio-melotti

Awaiting requested review from ezio-melotti

ezio-melotti is a code owner

hugovk

Awaiting requested review from hugovk

hugovk is a code owner

webknjaz

Awaiting requested review from webknjaz

webknjaz is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

freakboy3742 commented Mar 26, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

freakboy3742 commented Mar 26, 2026

Uh oh!

bedevere-bot commented Mar 26, 2026

Uh oh!

brianschubert commented Mar 26, 2026

Uh oh!

ned-deily left a comment

Choose a reason for hiding this comment

Uh oh!

freakboy3742 commented Mar 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

freakboy3742 commented Mar 26, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.