GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29548: no longer use PyEval_Call* functions by jdemeyer · Pull Request #14683 · python/cpython

Conversation

@jdemeyer

@jdemeyer jdemeyer commented Jul 10, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The PyEval_Call* functions should not be used anymore. This fixes the last few places where they are called within CPython.

CC @methane

https://bugs.python.org/issue29548

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jdemeyer
bpo-29548: no longer use PyEval_Call* functions
ba57e36
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 10, 2019
@bedevere-bot bedevere-bot added the awaiting review label Jul 10, 2019
zooba
zooba approved these changes Jul 11, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 11, 2019
@zooba zooba added the skip news label Jul 11, 2019
@zooba

zooba commented Jul 11, 2019

Copy link
Copy Markdown
Member

LMK if you'd like me to merge, or if you want additional review from someone else.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@methane
methane merged commit 1dbd084 into python:master Jul 11, 2019
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 11, 2019
@jdemeyer
jdemeyer deleted the no_pyeval_call branch July 11, 2019 21:04
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@jdemeyer @lisroach
bpo-29548: no longer use PyEval_Call* functions (pythonGH-14683)
bcbd45d
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@jdemeyer @DinoV
bpo-29548: no longer use PyEval_Call* functions (pythonGH-14683)
fe3b24c
@methane methane mentioned this pull request Aug 30, 2022
Recommend PyObject_Call* APIs over PyEval_Call*() APIs #73734
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jdemeyer @zooba @methane @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.