GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-143930: Fix typo in NEWS entry by benediktjohannes · Pull Request #147948 · python/cpython

Conversation

@benediktjohannes

@benediktjohannes benediktjohannes commented Mar 31, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

We do always include a "." at the end of the Whats New statement in the release notes (see

gh-143935: Fixed a bug in the folding of comments when flattening an email message using a modern email policy. Comments consisting of a very long sequence of non-foldable characters could trigger a forced line wrap that omitted the required leading space on the continuation line, causing the remainder of the comment to be interpreted as a new header field. This enabled header injection with carefully crafted inputs.

gh-143925: Reject control characters in data: URL media types.

gh-143919: Reject control characters in http.cookies.Morsel fields and values.

gh-143916: Reject C0 control characters within wsgiref.headers.Headers fields, values, and parameters.

)

And Benedikt Tran said that it's not necessary to open up an issue for just fixing a typo, but I don't know whether formating of the title is correct now because of the missing issue

  • Issue: Reject leading dashes in webbrowser.open() #143930

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benediktjohannes
[No issue, just a typo]: Add "."
c58ae75
@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label Mar 31, 2026
@github-project-automation github-project-automation Bot added this to Docs PRs Mar 31, 2026
@bedevere-app bedevere-app Bot added the awaiting review label Mar 31, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Mar 31, 2026
@benediktjohannes

benediktjohannes commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

Please apply skip issue, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz changed the title [No issue, just a typo]: Add "." in release notes statement gh-143930: Fix typo in NEWS entry Mar 31, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 31, 2026
Reject leading dashes in webbrowser.open() #143930
Closed
@StanFromIreland

StanFromIreland commented Mar 31, 2026

Copy link
Copy Markdown
Member

This can be included in #146476.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Mar 31, 2026

Copy link
Copy Markdown
Member

I don't think it's actually worth it. The NEWS entry was backported to security branches, so I prefer that it's amended in #146476 directly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz closed this Mar 31, 2026
@picnixz picnixz mentioned this pull request Mar 31, 2026
gh-143930: Tweak the exception message and increase test coverage #146476
Merged
@picnixz

picnixz commented Mar 31, 2026

Copy link
Copy Markdown
Member

Please apply skip issue, thanks!

As I said in the past, let maintainers decide what labels to add. Don't ask them please. In this case, a skip issue would not be correct and the change itself was not motivating enough as it would have required backports to security branches.
benediktjohannes reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benediktjohannes

benediktjohannes commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

Please apply skip issue, thanks!

As I said in the past, let maintainers decide what labels to add. Don't ask them please. In this case, a skip issue would not be correct and the change itself was not motivating enough as it would have required backports to security branches.

Ah, thank you for telling me about this, it's a good idea to use the other PR for this! 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benediktjohannes

benediktjohannes commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

And sorry for the label comment, I didn't ping anyone for this, I just thought that this label was correct and needed because the check failed, sorry, now I know for the future!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@benediktjohannes @StanFromIreland @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.