GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-143930: Tweak the exception message and increase test coverage by ambv · Pull Request #146476 · python/cpython

Conversation

@ambv

@ambv ambv commented Mar 26, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Based on comments left by Copilot on the backport PRs, there's two minor improvements that I made to the original vulnerability fix.

  • Issue: Reject leading dashes in webbrowser.open() #143930

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ambv added 2 commits March 26, 2026 17:50
@ambv
Use !r for the URL
f06681e
@ambv
Move dash test to CommandTestMixin and add it to MacOSXOSAScriptTest,…
32dbe7f 
… too
@ambv ambv added needs backport to 3.10 needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Mar 26, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 26, 2026
@ambv ambv added the skip news label Mar 26, 2026
@ambv
ambv requested a review from sethmlarson March 26, 2026 17:20
@bedevere-app bedevere-app Bot mentioned this pull request Mar 26, 2026
Reject leading dashes in webbrowser.open() #143930
Closed
sethmlarson
sethmlarson reviewed Mar 26, 2026
View reviewed changes
Comment thread Lib/test/test_webbrowser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland StanFromIreland mentioned this pull request Mar 31, 2026
gh-143930: Fix typo in NEWS entry #147948
Closed
@picnixz

picnixz commented Mar 31, 2026

Copy link
Copy Markdown
Member

@ambv Before merging can you include the changes in #147948 please?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz added the DO-NOT-MERGE label Mar 31, 2026
@picnixz

picnixz commented Mar 31, 2026

Copy link
Copy Markdown
Member

Adding a DO-NOT-MERGE so that you don't forget about it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ambv added 2 commits April 3, 2026 15:52
@ambv
Merge branch 'main' into pythongh-143930-followup
7e1f5c5
@ambv
Address nits from review, period.
b43743b
@ambv ambv removed DO-NOT-MERGE skip news labels Apr 3, 2026
@ambv
Make linter happy
33615c0
@ambv
ambv merged commit 3681d47 into python:main Apr 3, 2026
51 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 3, 2026
@miss-islington-app

miss-islington-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12, 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 3, 2026
@ambv @miss-islington
pythongh-143930: Tweak the exception message and increase test covera…
f7a9aca 
…ge (pythonGH-146476)

(cherry picked from commit 3681d47)

Co-authored-by: Łukasz Langa <[email protected]>
@miss-islington-app

miss-islington-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

Sorry, @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3681d47a440865aead912a054d4599087b4270dd 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

GH-148042 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned ambv Apr 3, 2026
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Apr 3, 2026
@miss-islington-app

miss-islington-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

Sorry, @ambv, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3681d47a440865aead912a054d4599087b4270dd 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

Sorry, @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3681d47a440865aead912a054d4599087b4270dd 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

Sorry, @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3681d47a440865aead912a054d4599087b4270dd 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ambv added a commit that referenced this pull request Apr 3, 2026
@miss-islington @ambv
[3.14] gh-143930: Tweak the exception message and increase test cover…
594b5a0 
…age (GH-146476) (GH-148042)

(cherry picked from commit 3681d47)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit to ambv/cpython that referenced this pull request Apr 3, 2026
@ambv
[3.13] pythongh-143930: Tweak the exception message and increase test…
a43f367 
… coverage (pythonGH-146476)

(cherry picked from commit 3681d47)

Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

GH-148045 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 3, 2026
ambv added a commit that referenced this pull request Apr 3, 2026
@ambv
[3.13] gh-143930: Tweak the exception message and increase test cover…
89bfb8e 
…age (GH-146476) (GH-148045)

(cherry picked from commit 3681d47)
@ambv ambv removed needs backport to 3.10 needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Apr 3, 2026
ambv added a commit to ambv/cpython that referenced this pull request Apr 3, 2026
@ambv
[3.12] pythongh-143930: Tweak the exception message and increase test…
d11a500 
… coverage (pythonGH-146476) (pythonGH-148045)

(cherry picked from commit 89bfb8e)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 3681d47)
ambv added a commit that referenced this pull request Apr 3, 2026
@ambv
[3.12] gh-143930: Tweak the exception message and increase test cover…
cc02351 
…age (GH-146476) (GH-148045) (GH-148051)

(cherry picked from commit 89bfb8e)
(cherry picked from commit 3681d47)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 3, 2026
@ambv @miss-islington
[3.12] pythongh-143930: Tweak the exception message and increase test…
e1dbc72 
… coverage (pythonGH-146476) (pythonGH-148045) (pythonGH-148051)

(cherry picked from commit cc02351)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 89bfb8e)
(cherry picked from commit 3681d47)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 3, 2026
@ambv @miss-islington
[3.12] pythongh-143930: Tweak the exception message and increase test…
0e0506c 
… coverage (pythonGH-146476) (pythonGH-148045) (pythonGH-148051)

(cherry picked from commit cc02351)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 89bfb8e)
(cherry picked from commit 3681d47)
ambv added a commit that referenced this pull request Apr 3, 2026
@miss-islington @ambv
[3.10] gh-143930: Tweak the exception message and increase test cover…
591ed89 
…age (GH-146476) (GH-148045) (GH-148051) (GH-148053)

(cherry picked from commit cc02351)
(cherry picked from commit 89bfb8e)
(cherry picked from commit 3681d47)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Apr 3, 2026
@miss-islington @ambv
[3.11] gh-143930: Tweak the exception message and increase test cover…
96fc504 
…age (GH-146476) (GH-148045) (GH-148051) (GH-148052)

(cherry picked from commit cc02351)
(cherry picked from commit 89bfb8e)
(cherry picked from commit 3681d47)

Co-authored-by: Łukasz Langa <[email protected]>
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@ambv @ljfp
pythongh-143930: Tweak the exception message and increase test covera…
ec82537 
…ge (pythonGH-146476)
icanhasmath pushed a commit to ActiveState/cpython that referenced this pull request Oct 28, 2026
@miss-islington @ambv @icanhasmath
[3.10] pythongh-143930: Tweak the exception message and increase test…
6f18487 
… coverage (pythonGH-146476) (pythonGH-148045) (pythonGH-148051) (pythonGH-148053)

(cherry picked from commit cc02351)
(cherry picked from commit 89bfb8e)
(cherry picked from commit 3681d47)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 591ed89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethmlarson sethmlarson sethmlarson left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ambv ambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ambv @picnixz @sethmlarson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.