GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131798: split recursion check to _CHECK_RECURSION_LIMIT and combine checks by kumaraditya303 · Pull Request #148070 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Apr 4, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Better uop coverage in the JIT optimizer #131798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
split recursion check to _CHECK_RECURSION_LIMIT
db7d8e6
@kumaraditya303
kumaraditya303 requested a review from markshannon as a code owner April 4, 2026 06:25
@kumaraditya303 kumaraditya303 added the skip news label Apr 4, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 4, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Apr 4, 2026
Better uop coverage in the JIT optimizer #131798
Open
@kumaraditya303
optimize it as well
7c1d63f
@kumaraditya303
kumaraditya303 requested review from Fidget-Spinner, savannahostrowski and tomasr8 as code owners April 4, 2026 06:35
@Fidget-Spinner Fidget-Spinner changed the title gh-131798: split recursion check to _CHECK_RECURSION_LIMIT gh-131798: split recursion check to _CHECK_RECURSION_LIMIT and comine checks Apr 4, 2026
@kumaraditya303 kumaraditya303 changed the title gh-131798: split recursion check to _CHECK_RECURSION_LIMIT and comine checks gh-131798: split recursion check to _CHECK_RECURSION_LIMIT and combine checks Apr 4, 2026
Fidget-Spinner
Fidget-Spinner approved these changes Apr 4, 2026
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key idea here is to combine recursion stack space limit checks into the first one. This is safe to do per-frame as subsequent calls should always return the frame to the same state according to how calls in C work.

Note that this is NOT the py recursion limit, which will require executor invalidation during sys setrecursionlimit to handle.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Include/internal/pycore_optimizer_types.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 4, 2026
@kumaraditya303
rename to is_c_recursion_checked
50c4184
@Fidget-Spinner
Fidget-Spinner merged commit e7bf8ea into python:main Apr 4, 2026
114 of 117 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 4, 2026
@kumaraditya303
kumaraditya303 deleted the recursion branch April 4, 2026 09:23
@kumaraditya303 kumaraditya303 added the topic-JIT label Apr 4, 2026
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@kumaraditya303 @ljfp
pythongh-131798: split recursion check to _CHECK_RECURSION_LIMIT and …
cf8c02b 
…combine checks (pythonGH-148070)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kumaraditya303 @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.