GeezerVison

Also add Linux poison tests that corrupt both the main and asyncio offset tables and assert that RemoteUnwinder fails with an invalid-offset error instead of walking into bad accesses or misleading late failures.

Where are they?

I'm also wondering about char[] buffers and GET_MEMBER? I'm thinking about alignment of offsets for a given type. Perhaps there's a risk of undefined behaviour there as well. Do we care about it?

I decided to remove the tests because there were stupidly long, verbose (as I am basically parsing elf by hand in Python), only worked on Linux and has reduced value (just one way to trigger it not all of them) and the Pr is already quite big but I didn't update the commit message

You can see them in the diff here https://github.com/python/cpython/compare/f12f6c4f0467837e25a445339f2e5a24388a317d..b8dcd8fa2b3be846b1dad6d2afb1dccd968789b3

I'm also wondering about char[] buffers and GET_MEMBER? I'm thinking about alignment of offsets for a given type. Perhaps there's a risk of undefined behaviour there as well. Do we care about it?

I don't think so. But if you have a specific suggestion code suggestion happy to consider it ;)

@pablogsal

I think the easiest would be:

-#define GET_MEMBER(type, obj, offset) (*(type*)((char*)(obj) + (offset)))
+#define GET_MEMBER(type, obj, offset) (*(const type *)memcpy(&(type){0}, (const char *)(obj) + (offset), sizeof(type)))

I did not test it, but looks the least disruptive. I was only able to confirm the issue w/ UBSan

You already do use memcpy:)

https://github.com/python/cpython/blob/30c698a655ba/Modules/_remote_debugging/binary_io_reader.c#L47-L51

I'd love to submit a PR but I think it should be based on yours, not the main branch. I'd definitely include some fail-fast in validate_field() and add field_alignment next to field_size. If you're ok, should be under gh-148178?

@maurycy you can create a pr targetting this branch in my fork if you want

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

Sorry, @pablogsal, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 289fd2c97a7e5aecb8b69f94f5e838ccfeee7e67 3.14

GH-148577 is a backport of this pull request to the 3.14 branch.