GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-148222 Fix Null dereference bugs at genericaliasobject.c by prakashsellathurai · Pull Request #148226 · python/cpython

Conversation

prakashsellathurai commented Apr 7, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: genericaliasobject.c: Two NULL dereference bugs #148222

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

prakashsellathurai added 4 commits

April 7, 2026 20:16


          Add Add NULL check and fallback to ga_vectorcall

c954f91


          Add Null check to _Py_make_parameters when_PyTuple_Resize fails and

01faae2

parameter is null


          Merge branch 'python:main' into fix/148222

eb56ccf


          add changelog

31b5522

bedevere-app Bot added the awaiting review label

Apr 7, 2026

bedevere-app Bot mentioned this pull request

Apr 7, 2026

genericaliasobject.c: Two NULL dereference bugs #148222

Closed

prakashsellathurai added 2 commits

April 7, 2026 20:46


          style: fix liting error

e6a5d95


          Merge branch 'python:main' into fix/148222

d7cccef

JelleZijlstra reviewed

Apr 7, 2026

View reviewed changes

Comment thread

Objects/genericaliasobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra reviewed

Apr 7, 2026

View reviewed changes

Comment thread

Objects/genericaliasobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

prakashsellathurai added 4 commits

April 8, 2026 19:38


          Merge branch 'python:main' into fix/148222

916a046


          remove reduntant Py_XDECREF(param) call in genricalias object call

1defe5d


          remove redunatnt PyVectorcall_Function call in generic alias object c

99b1ce9


          Update 2026-04-07-20-37-23.gh-issue-148222.uF4D4E.rst

b93f0bf

prakashsellathurai requested review from JelleZijlstra and serhiy-storchaka

April 9, 2026 05:43


          Merge branch 'main' into fix/148222

1664d37

serhiy-storchaka reviewed

Apr 13, 2026

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to write a test for the vectorcall part?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Misc/NEWS.d/next/Core_and_Builtins/2026-04-07-20-37-23.gh-issue-148222.uF4D4E.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update 2026-04-07-20-37-23.gh-issue-148222.uF4D4E.rst

a3ad3ef

serhiy-storchaka reviewed

Apr 13, 2026

View reviewed changes

Comment thread

Misc/NEWS.d/next/Core_and_Builtins/2026-04-07-20-37-23.gh-issue-148222.uF4D4E.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

prakashsellathurai added 2 commits

April 14, 2026 12:48


          Update 2026-04-07-20-37-23.gh-issue-148222.uF4D4E.rst

3a78f45


          Delete crash_test.py

60378b0

prakashsellathurai commented Apr 14, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

Is it possible to write a test for the vectorcall part?
@serhiy-storchaka

I spent some time on this. since this bug occurs at C implementations level, we cannot reproduce in python unit tests.

also with custom _testcapi extension i am not ably to reliably simulate that exact flow

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka approved these changes

Apr 14, 2026

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

Apr 14, 2026

prakashsellathurai commented Apr 17, 2026

Copy link

Copy Markdown

Contributor Author

@serhiy-storchaka thanks for the pr review.

all checks are passing. Since I don't have merge access, could you please merge this when you get a chance? Thank you!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra added needs backport to 3.13

only security fixes

needs backport to 3.14 bugs and security fixes labels

Apr 18, 2026

JelleZijlstra merged commit 634568d into python:main

Apr 18, 2026

62 checks passed

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Apr 18, 2026

miss-islington-app Bot commented Apr 18, 2026

Copy link

Copy Markdown

Thanks @prakashsellathurai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 18, 2026


          pythongh-148222: Fix NULL dereference bugs in genericaliasobject.c (p…

559c63c

…ythonGH-148226)

(cherry picked from commit 634568d)

Co-authored-by: Prakash Sellathurai <[email protected]>

bedevere-app Bot commented Apr 18, 2026

Copy link

Copy Markdown

GH-148705 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Apr 18, 2026

Copy link

Copy Markdown

Sorry, @prakashsellathurai and @JelleZijlstra, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 634568d030f18183212c01bd4544aa7f97e05442 3.13

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Apr 18, 2026

miss-islington-app Bot assigned JelleZijlstra

Apr 18, 2026

JelleZijlstra commented Apr 18, 2026

Copy link

Copy Markdown

Member

Would you mind checking if the bug is also present on the 3.13 branch and backport it to 3.13 if so?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra pushed a commit that referenced this pull request

Apr 18, 2026


          [3.14] gh-148222: Fix NULL dereference bugs in genericaliasobject.c (G…

67100b3

…H-148226) (#148705)

gh-148222: Fix NULL dereference bugs in genericaliasobject.c (GH-148226)
(cherry picked from commit 634568d)

Co-authored-by: Prakash Sellathurai <[email protected]>

prakashsellathurai added a commit to prakashsellathurai/cpython that referenced this pull request

Apr 18, 2026


          pythongh-148222: Fix NULL dereference bugs in genericaliasobject.c (p…

6a8f75a

…ython#148226)

(cherry picked from commit 634568d)

bedevere-app Bot commented Apr 18, 2026

Copy link

Copy Markdown

GH-148712 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot commented Apr 18, 2026

Copy link

Copy Markdown

GH-148712 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Apr 18, 2026

prakashsellathurai added a commit to prakashsellathurai/cpython that referenced this pull request

Apr 18, 2026


          [3.13] pythongh-148222: Fix NULL dereference bugs in genericaliasobje…

83552a6

…ct.c (python#148226)

(cherry picked from commit 634568d)

bedevere-app Bot commented Apr 18, 2026

Copy link

Copy Markdown

GH-148717 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

prakashsellathurai commented Apr 18, 2026

Copy link

Copy Markdown

Contributor Author

Would you mind checking if the bug is also present on the 3.13 branch and backport it to 3.13 if so?

@JelleZijlstra raised backport to 3.13 in #148717

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

prakashsellathurai added a commit to prakashsellathurai/cpython that referenced this pull request

Apr 18, 2026


          Revert "[3.13] pythongh-148222: Fix NULL dereference bugs in generica…

…liasobject.c (python#148226)"

This reverts commit 83552a6.

prakashsellathurai added a commit to prakashsellathurai/cpython that referenced this pull request

Apr 18, 2026


          [3.13] pythongh-148222: Fix NULL dereference bugs in genericaliasobje…

7aca63f

…ct.c (python#148226)

(cherry picked from commit 634568d)

JelleZijlstra pushed a commit that referenced this pull request

Apr 18, 2026


          [3.13] gh-148222: Fix NULL dereference bugs in genericaliasobject.c (G…

0ca5390

…H-148226) (#148717)

(cherry picked from commit 634568d)

ljfp pushed a commit to ljfp/cpython that referenced this pull request

Apr 25, 2026


          pythongh-148222: Fix NULL dereference bugs in genericaliasobject.c (p…

aab45e0

…ython#148226)

aisk mentioned this pull request

May 21, 2026

Umbrella issue: bugs found using cpython-review-toolkit #146102

Open

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

JelleZijlstra

Awaiting requested review from JelleZijlstra

Uh oh!

There was an error while loading. Please reload this page.

Assignees

JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

prakashsellathurai commented Apr 7, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

prakashsellathurai commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

prakashsellathurai commented Apr 17, 2026

Uh oh!

Uh oh!

miss-islington-app Bot commented Apr 18, 2026

Uh oh!

bedevere-app Bot commented Apr 18, 2026

Uh oh!

miss-islington-app Bot commented Apr 18, 2026

Uh oh!

JelleZijlstra commented Apr 18, 2026

Uh oh!

bedevere-app Bot commented Apr 18, 2026

Uh oh!

bedevere-app Bot commented Apr 18, 2026

Uh oh!

bedevere-app Bot commented Apr 18, 2026

Uh oh!

prakashsellathurai commented Apr 18, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

prakashsellathurai commented Apr 7, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

prakashsellathurai commented Apr 14, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.