GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-148211: decompose `[_POP_CALL_X/_SHUFFLE_2]_LOAD_CONST_INLINE_BORROW` in JIT by NekoAsakura · Pull Request #148313 · python/cpython

Conversation

NekoAsakura commented Apr 9, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Refactor the JIT uops #148211

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-148211: decompose `[_POP_CALL_X/_SHUFFLE_2]_LOAD_CONST_INLIN…

b88b7d2

…E_BORROW` in JIT

NekoAsakura requested review from Fidget-Spinner, markshannon, savannahostrowski and tomasr8 as code owners

April 9, 2026 20:57

bedevere-app Bot added the awaiting review label

Apr 9, 2026

bedevere-app Bot mentioned this pull request

Apr 9, 2026

Refactor the JIT uops #148211

Closed

Fidget-Spinner added the skip news label

Apr 9, 2026

Fidget-Spinner approved these changes

Apr 9, 2026

View reviewed changes

Fidget-Spinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines changed: 1040 additions & 1411 deletions

Now that's what I like to see!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

NekoAsakura reacted with laugh emoji

All reactions

😄 1 reaction

Comment thread

Python/optimizer_bytecodes.c

		}
		sym_set_const(res, out);
		ADD_OP(_POP_CALL_TWO_LOAD_CONST_INLINE_BORROW, 0, (uintptr_t)out);
		ADD_OP(_POP_CALL_TWO, 0, 0);

Fidget-Spinner Apr 9, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should get rid of this into POP_TOP, POP_TOP, POP_TOP_NOP, POP_TOP in the next PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

NekoAsakura Apr 9, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to decompose _POP_TWO_LOAD_CONST_INLINE_BORROW and _INSERT_2_LOAD_CONST_INLINE_BORROW and get shot of _POP_TOP_LOAD_CONST_INLINE(_BORROW) we left in #148230 in the next PR. I'll sort _POP_CALL* into individual pops after that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Fidget-Spinner Apr 9, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

Apr 9, 2026

Fidget-Spinner merged commit aea0b91 into python:main

Apr 10, 2026

82 checks passed

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Apr 10, 2026

NekoAsakura deleted the gh-148211/decompose-pop-call branch

April 10, 2026 13:57

ljfp pushed a commit to ljfp/cpython that referenced this pull request

Apr 25, 2026


          pythongh-148211: decompose `[_POP_CALL_X/_SHUFFLE_2]_LOAD_CONST_INLIN…

c354488

…E_BORROW` in JIT (pythonGH-148313)

Reviewers

Fidget-Spinner

Fidget-Spinner approved these changes

markshannon

Awaiting requested review from markshannon

markshannon is a code owner

tomasr8

Awaiting requested review from tomasr8

tomasr8 is a code owner

savannahostrowski

Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

NekoAsakura commented Apr 9, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fidget-Spinner left a comment

Choose a reason for hiding this comment

Uh oh!

Fidget-Spinner Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

NekoAsakura Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Fidget-Spinner Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NekoAsakura commented Apr 9, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.