GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — CI: Move Homebrew dependencies into Brewfile by hugovk · Pull Request #148335 · python/cpython Conversation
| |||||||||||||||||||||||||||||||||||||||||||||||||
| run: | | ||
| brew install pkg-config [email protected] xz gdbm tcl-tk@9 make | ||
| # Because alternate versions are not symlinked into place by default: | ||
| brew link --overwrite tcl-tk@9 |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Will backport to 3.10, but we still need to link tcl-tk@8 there. And put tcl-tk@8 in the Brewfile.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I like the idea but not sure if the file location should be among the workflows.. Perhaps, it'd belong in the tools dir?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Good point: if we move it elsewhere, we can update https://devguide.python.org/getting-started/setup-building/ -brew install pkg-config openssl@3 xz gdbm tcl-tk mpdecimal zstd +brew bundle --file=<file-location> |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| @@ -0,0 +1,6 @@ | |||
| brew "gdbm" | |||
| brew "make" | |||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to install a third-party make? We've always just used the Apple-supplied one as shown in the devguide.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Hmm, let's see...
It was added in #123020 because BSD make (the macOS default) was found to have a race condition when writing output to file across multiple jobs. We needed the output file to postprocess warnings.
And GNU make (from Homebrew, executable gmake) has --output-sync which prevents this race.
See resolved comment thread at #123020 (comment).
So we can move make out of the Brewfile, because we don't want that as part of the devguide recommendation, and do keep regular brew install make on CI.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
There's also the potential to make this work with Linux as well (example of how to do that). The |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Back in the day this would have gone into |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Moved to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Side note:
Personally, I'd go for |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
The reason I suggested the options for Homebrew on Linux is:
But I personally have no objection against bindep. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Documentation build overview
77 files changed ·
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-149882 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @hugovk, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @hugovk, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-149883 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-149884 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| brew "zstd" | ||
|
|
||
| brew "bzip2" if OS.linux? | ||
| brew "expat" if OS.linux? |
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Why expat, since we bundle it, should it also not be an option?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
It's what Homebrew's own formula has for CPython, so I just went with it without thinking. It could probably come out in hindsight.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
They also pass --with-system-expat: https://github.com/Homebrew/homebrew-core/blob/bc720062efe831cb785ffd3b288b6a090ec9d2ac/Formula/p/python%403.14.rb#L136
Sorry, something went wrong.
There was an error while loading. Please reload this page.
) Co-authored-by: Brett Cannon <[email protected]>
) Co-authored-by: Brett Cannon <[email protected]>
…49884) (#149990) Co-authored-by: Brett Cannon <[email protected]>
…49884) (#149988) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Brett Cannon <[email protected]>
) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Brett Cannon <[email protected]>
…49884) (#149989) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Brett Cannon <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.