GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-148398: add type watcher in `_CHECK_ATTR_CLASS` by NekoAsakura · Pull Request #148399 · python/cpython

Conversation

@NekoAsakura

@NekoAsakura NekoAsakura commented Apr 11, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: JIT: missing type watcher in _CHECK_ATTR_CLASS #148398

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@NekoAsakura
pythongh-148398: add type watcher in _CHECK_ATTR_CLASS
ca70b69
@NekoAsakura
NekoAsakura requested review from Fidget-Spinner, markshannon, savannahostrowski and tomasr8 as code owners April 11, 2026 19:00
@bedevere-app bedevere-app Bot added the awaiting review label Apr 11, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Apr 11, 2026
JIT: missing type watcher in _CHECK_ATTR_CLASS #148398
Closed
@Fidget-Spinner

Fidget-Spinner commented Apr 11, 2026

Copy link
Copy Markdown
Member

I'm not sure whether this went out in an alpha. If it did you probably need a shorts news entry about fixing a bug.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@NekoAsakura

NekoAsakura commented Apr 11, 2026

Copy link
Copy Markdown
Member Author

Yes, it's been in since a1. I will write it.
Fidget-Spinner reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
NekoAsakura added 2 commits April 11, 2026 15:18
@NekoAsakura
pythongh-148398: add NEWS
6ee2de7
@NekoAsakura
Merge branch 'main' into pythongh-148398/add-type-watcher
8cb0b3c
kumaraditya303
kumaraditya303 reviewed Apr 12, 2026
View reviewed changes
Comment thread Python/optimizer_bytecodes.c Outdated
}
else {
sym_set_const(owner, type);
PyType_Watch(TYPE_WATCHER_ID, type);

@kumaraditya303 kumaraditya303 Apr 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to add type watcher if type is immutable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
NekoAsakura reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@Fidget-Spinner Fidget-Spinner Apr 12, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref #148383

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
NekoAsakura reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@NekoAsakura
pythongh-148398: add type watcher in _CHECK_ATTR_CLASS
c1eeb13
kumaraditya303
kumaraditya303 approved these changes Apr 12, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 12, 2026
@Fidget-Spinner
Fidget-Spinner merged commit 30c698a into python:main Apr 12, 2026
76 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 12, 2026
@NekoAsakura
NekoAsakura deleted the gh-148398/add-type-watcher branch April 12, 2026 21:16
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@NekoAsakura @ljfp
pythongh-148398: add type watcher in _CHECK_ATTR_CLASS (pythonGH-14…
8c88400 
…8399)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@NekoAsakura @Fidget-Spinner @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.