GeezerVison is showing github.com — gh-131798: JIT: Optimize `_CHECK_IS_NOT_PY_CALLABLE_EX` and `_CHECK_IS_NOT_PY_CALLABLE_KW` by Wulian233 · Pull Request #148494 · python/cpython
Conversation
Wulian233
commented
Apr 13, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
While implementing this, I ran into a confusing problem. As shown in the diff below, when I assign f = sorted instead of calling sorted() directly, the JIT fails to recognize the optimization, causing the test to fail.
def test_check_is_not_py_callable_kw(self):
def testfunc(n):
total = 0
- xs = (3, 1, 2)
- for _ in range(n):
- total += sorted(xs, reverse=False)[0]
+ f = sorted
+ xs = (3, 1, 2)
+ for _ in range(n):
+ total += f(xs, reverse=False)[0]
return total
res, ex = self._run_with_optimizer(testfunc, TIER2_THRESHOLD)
self.assertEqual(res, TIER2_THRESHOLD)
self.assertIsNotNone(ex)
uops = get_opnames(ex)
self.assertNotIn("_CHECK_IS_NOT_PY_CALLABLE_KW", uops)
Edit: Please add skip news
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…HECK_IS_NOT_PY_CALLABLE_EX`
While implementing this, I ran into a confusing problem. As shown in the diff below, when I assign f = sorted instead of calling sorted() directly, the JIT fails to recognize the optimization, causing the test to fail.
That's not really a problem, just how the JIT behaves. We only compile the region inside the for loop first, and then a function only if it's hot enough. As for the code example above you placed the sorted outside the for loop, the JIT has no visibility of it.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
oh I understand, thank you!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
Reviewers
markshannon
Awaiting requested review from markshannon
markshannon is a code owner
tomasr8
Awaiting requested review from tomasr8
tomasr8 is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|