GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131798: Constant-fold `_CONTAINS_OP_DICT` for frozendict by Wulian233 · Pull Request #148548 · python/cpython

Conversation

@Wulian233

@Wulian233 Wulian233 commented Apr 14, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

#148084 has already done the frozenset optimization for _CONTAINS_OP_SET. Similarly, _CONTAINS_OP_DICT can be handled in the same way.

That PR added news, which I haven't added yet. If needed, I can add later

  • Issue: Better uop coverage in the JIT optimizer #131798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Wulian233
pythongh-131798: Constant-fold _CONTAINS_OP_DICT for frozendict
ef83f33
@Wulian233
Wulian233 requested review from Fidget-Spinner, markshannon, savannahostrowski and tomasr8 as code owners April 14, 2026 11:53
@bedevere-app bedevere-app Bot added the awaiting review label Apr 14, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Apr 14, 2026
Better uop coverage in the JIT optimizer #131798
Open
Sacul0457
Sacul0457 reviewed Apr 14, 2026
View reviewed changes
Comment thread Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233
_LOAD_CONST_INLINE_BORROW
ba0ebf8
@Fidget-Spinner Fidget-Spinner added the skip news label Apr 14, 2026
@Wulian233
count_ops
157202e
Fidget-Spinner
Fidget-Spinner approved these changes Apr 14, 2026
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 14, 2026
@Fidget-Spinner
Fidget-Spinner merged commit e0b56f0 into python:main Apr 14, 2026
73 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 14, 2026
@Wulian233
Wulian233 deleted the _CONTAINS_OP_DICT branch April 14, 2026 18:30
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@Wulian233 @ljfp
pythongh-131798: Constant-fold _CONTAINS_OP_DICT for frozendict (py…
1cfaf74 
…thonGH-148548)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski
+1 more reviewer
@Sacul0457 Sacul0457 Sacul0457 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Wulian233 @Fidget-Spinner @Sacul0457
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.