GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-145278: also filter mmap2 in strace_helper.filter_memory by FFY00 · Pull Request #148648 · python/cpython

Conversation

@FFY00

@FFY00 FFY00 commented Apr 16, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Freeze modules used during startup #145278

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@FFY00
pythonGH-145278: also filter mmap2 in strace_helper.filter_memory
1880772 
Signed-off-by: Filipe Laíns <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 16, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Apr 16, 2026
Freeze modules used during startup #145278
Closed
@FFY00 FFY00 added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Apr 16, 2026
@bedevere-bot

bedevere-bot commented Apr 16, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @FFY00 for commit 1880772 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F148648%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2026
@FFY00
FFY00 requested a review from encukou April 16, 2026 13:24
@FFY00 FFY00 mentioned this pull request Apr 16, 2026
GH-145278: freeze encodings (partially) and linecache #148347
Merged
vstinner
vstinner approved these changes Apr 16, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 16, 2026
@vstinner

vstinner commented Apr 16, 2026

Copy link
Copy Markdown
Member

We should wait for "ARM Raspbian 3.x" buildbot worker to report if tests pass or not. Right now, there are two queued job on "ARM Raspbian PR": https://buildbot.python.org/#/builders/1062.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FFY00

FFY00 commented Apr 16, 2026

Copy link
Copy Markdown
Member Author

Yep, I am monitoring it to see if this change actually fixes the buildbot failure 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FFY00

FFY00 commented Apr 16, 2026

Copy link
Copy Markdown
Member Author

Raspbian seems to be passing now.

https://buildbot.python.org/all/#/builders/1062/builds/1357

I'll wait for the rest of the buildbots to finish, and then I'll merge.
encukou reacted with thumbs up emoji vstinner reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Apr 16, 2026
gh-146636: Improve ABI/feature selection, add new header for it #148302
Merged
cmaloney
cmaloney reviewed Apr 16, 2026
View reviewed changes
Comment thread Lib/test/support/strace_helper.py
def _filter_memory_call(call):
# mmap can operate on a fd or "MAP_ANONYMOUS" which gives a block of memory.
# Ignore "MAP_ANONYMOUS + the "MAP_ANON" alias.
if call.syscall == "mmap" and "MAP_ANON" in call.args[3]:

@cmaloney cmaloney Apr 16, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also would be happy with call.syscall.startswith('mmap') here as a guard against mmap3 / future extensions as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou

encukou commented Apr 20, 2026

Copy link
Copy Markdown
Member

PR Buildbots are green; I'll merge.

startswith can go in the next PR -- third time's the charm, right?
cmaloney reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit 513db72 into python:main Apr 20, 2026
126 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 20, 2026
@cmaloney

cmaloney commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

This is more like 5th ><. There were a couple reverts getting bots clean to land the strace testing infrastructure...

If there is a more reliable way to check for accidental additions of stat or read system calls when reading a file am all ears. At least 3 times before the strace test people optimized and then more calls were accidentally added...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Apr 21, 2026

Copy link
Copy Markdown
Member

Well, the best way to classify accidental vs. intended additions is, still, human review. Can we make that easier? Perhaps change an error message to point to the place to fix?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@FFY00 @ljfp
pythonGH-145278: also filter mmap2 in strace_helper.filter_memory (py…
3a9ed7e 
…thonGH-148648)

Signed-off-by: Filipe Laíns <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmaloney cmaloney cmaloney left review comments
@vstinner vstinner vstinner approved these changes
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@FFY00 @bedevere-bot @vstinner @encukou @cmaloney
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.