GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-148675: Revert GH-146237 and GH-146241 by skirpichev · Pull Request #148674 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Apr 17, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

📚 Documentation preview 📚: https://cpython-previews--148674.org.readthedocs.build/

  • Issue: Add support for numpy buffer format Zf and Zd #148675

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
skirpichev added 2 commits April 17, 2026 14:28
@skirpichev
Revert "pythongh-146151: Add support for complex arrays in the array …
5c606ee 
…module (python#146237)"

This reverts commit 0e3b3b8.
@skirpichev
Revert "pythongh-146151: memoryview supports 'F' and 'D' format types…
760e2f0 
… (complex) (python#146241)"

This reverts commit c68a194.
@skirpichev skirpichev added skip issue skip news labels Apr 17, 2026
@skirpichev skirpichev mentioned this pull request Apr 17, 2026
gh-146151: support for complex arrays in the array module #146237
Merged
@skirpichev
+1
a2d8035
@skirpichev skirpichev mentioned this pull request Apr 17, 2026
Decide buffer protocol format string for complex numbers python/steering-council#345
Closed
@skirpichev
skirpichev marked this pull request as ready for review April 17, 2026 11:52
@skirpichev
skirpichev requested a review from AA-Turner as a code owner April 17, 2026 11:52
@bedevere-app bedevere-app Bot added the awaiting review label Apr 17, 2026
@skirpichev skirpichev mentioned this pull request Apr 17, 2026
Add support for numpy buffer format Zf and Zd #148675
Closed
@skirpichev skirpichev changed the title Revert PR 146237 and PR 146241 gh-148675: Revert PR 146237 and PR 146241 Apr 17, 2026
@skirpichev skirpichev removed the skip issue label Apr 17, 2026
@picnixz picnixz changed the title gh-148675: Revert PR 146237 and PR 146241 gh-148675: Revert GH-146237 and GH-146241 Apr 19, 2026
@skirpichev skirpichev mentioned this pull request May 4, 2026
gh-121249: remove F/D type codes from table in the struct module #149346
Merged
@skirpichev
skirpichev requested review from encukou, hugovk and vstinner May 4, 2026 10:42
@vstinner

vstinner commented May 4, 2026

Copy link
Copy Markdown
Member

I merged my change PR gh-148676 which adds Zf/Zd formats to array, ctypes, memoryview and struct. It created many conflicts with this PR.

So I created PR gh-149368 to remove F and D formats from array and memoryview: it's similar to this change but it leaves Zf/Zd in place.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev skirpichev closed this May 4, 2026
@skirpichev
skirpichev deleted the revert-146237and146241 branch May 4, 2026 15:04
@skirpichev

skirpichev commented May 4, 2026

Copy link
Copy Markdown
Member Author

I merged my change PR #148676

Shouldn't this be approved by some other core developer?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 4, 2026

Copy link
Copy Markdown
Member

Usually, yes, I prefer to wait for an approval of another core dev. In this case, I rushed to merge the PR to make sure that it lands into Python 3.15 alpha1. I don't like working under pressure like that. I hope that we will time to digest these changes and cleanup the code and the doc before Python 3.15 final.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@vstinner vstinner Awaiting requested review from vstinner
@encukou encukou Awaiting requested review from encukou
@hugovk hugovk Awaiting requested review from hugovk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@skirpichev @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.