GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — gh-121249: remove F/D type codes from table in the struct module by skirpichev · Pull Request #149346 · python/cpython Conversation
|
Documentation build overview
212 files changed ·
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
What is the reason for deprecation? Also, why is it linked to an issue closed long time ago? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
It's an alternative to #148676, see python/steering-council#345 (comment) There are 3 PRs:
Reopened, thanks. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm -1. @hugovk any objections to deprecating in a later beta, rather than b1? That would mean we don't need to decide now. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I removed F/D types from the table and postponed removal to 3.20. I think it's now along line of using two-letters type codes CC @vstinner Edit: Alternatively - we could just drop old type codes from the table (no deprecation). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It's too late to introduce a deprecation in Python 3.15. We can reconsider a deprecation in Python 3.16. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I would like to hear the Steering Council opinion on this question. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
@vstinner, what does require SC decision on this? It's regular documentation change, no deprecations. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
CC @warsaw as SC voice in python/steering-council#345, per Victor's request. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I created the issue python/steering-council#352 for the Steering Council to "Deprecated F and D format in the struct module in Python 3.16". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hi, the SC decision is to soft deprecate in Python 3.15 and deprecate in Python 3.16: python/steering-council#352 (comment) Currently, the PR does soft deprecate in Python 3.16. Do you want to create a Python 3.15 PR to soft deprecate and a Python 3.16 to deprecate? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
No, it does this for v3.15 entry. I'll add news entry and then this will be ready for a backport. I'll do a separate pr for v3.16 one something like this (soft-deprecation) will be merged. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
I see that the soft deprecation must be documented in What's New In Python 3.15 document which is also part of the main branch, so ok, it makes sense :-) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @skirpichev and @vstinner, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-152274 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
#152274) gh-121249: Soft deprecate F and D struct format types (#149346) Remove F/D type codes from table in the struct module documentation. (cherry picked from commit 5f17434) Co-authored-by: Sergey B Kirpichev <[email protected]>
|
Thanks, I merged your PR to soft deprecate F and D type codes. I'm now waiting for your 3.16 change to (hard) deprecate these type codes :-) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
FYI: #152309 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.