GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-148680: Replace internal names with type_reprs of objects in string representations of ForwardRef by DavidCEllis · Pull Request #148682 · python/cpython

gh-148680: Replace internal names with type_reprs of objects in string representations of ForwardRef #148682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 11 commits into python:main from DavidCEllis:fix-forwardref-string-names
Apr 23, 2026

Uh oh!

There was an error while loading. Please reload this page.
Merged

gh-148680: Replace internal names with type_reprs of objects in string representations of ForwardRef #148682

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
12d7a45
Add tests for replacement of extra names in repr and string evaluation
DavidCEllis Apr 17, 2026
e1e258e
Replace names from __extra_names__ when evaluating forward references…
DavidCEllis Apr 17, 2026
ade5f8e
Try to write a clearer comment
DavidCEllis Apr 17, 2026
f3b6293
Make the repr test use retrieved rather than 'artificial' forward ref…
DavidCEllis Apr 17, 2026
675738a
Add a cache for resolved str, test the cache is used, shorten names
DavidCEllis Apr 20, 2026
5a36751
Update Lib/annotationlib.py
DavidCEllis Apr 20, 2026
3d9b64a
remove unnecessary and incorrect node 'fixup'.
DavidCEllis Apr 20, 2026
57bfa41
Remove optimization for a condition that should never be hit normally
DavidCEllis Apr 20, 2026
3d08f8f
Remove 'synthetic' test, make the regular test replace additional values
DavidCEllis Apr 20, 2026
5de5e01
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 23, 2026
4ff6eeb
Fix linting issue (maybe)
DavidCEllis Apr 23, 2026
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/annotationlib.py 
Fix a misplaced parenthesis that incorrectly caused a statement to evaluate as truthy

Co-authored-by: Shamil <[email protected]>
  • Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

@DavidCEllis @ashm-dev
DavidCEllis and ashm-dev authored Apr 20, 2026
commit 5a36751da10b5dfdd5d4a830c3fe46a7f2aa13e7

Some comments aren't visible on the classic Files Changed page.

There are no files selected for viewing

2 changes: 1 addition & 1 deletion 2 Lib/annotationlib.py
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ def __resolved_str__(self):
if names:
# identifiers can be replaced directly
if resolved_str.isidentifier():
if (name_obj := names.get(resolved_str), _sentinel) is not _sentinel:
if (name_obj := names.get(resolved_str, _sentinel)) is not _sentinel:
resolved_str = type_repr(name_obj)
else:
visitor = _ExtraNameFixer(names)
Expand Down
Loading
Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.