GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-148967: Fix FFI type pointer handling for C complex support in set_stginfo_ffi_type_pointer by sunmy2019 · Pull Request #148969 · python/cpython

Conversation

@sunmy2019

@sunmy2019 sunmy2019 commented Apr 24, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The else branch is taken from the earlier _ctype.c.

  • Issue: Guard _Py_FFI_SUPPORT_C_COMPLEX for complex check in ctypes #148967

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sunmy2019
Fix FFI type pointer handling for C complex support in set_stginfo_ff…
d37a507 
…i_type_pointer
@bedevere-app bedevere-app Bot added the awaiting review label Apr 24, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Apr 24, 2026
Guard _Py_FFI_SUPPORT_C_COMPLEX for complex check in ctypes #148967
Closed
@sunmy2019
sunmy2019 requested review from encukou and skirpichev April 24, 2026 17:55
@sunmy2019
Merge branch 'main' into pythongh-148967
6d85124
@sunmy2019

sunmy2019 commented Apr 24, 2026

Copy link
Copy Markdown
Member Author

I don't think we need to add NEWs. The regression is just introduced by 769cc83.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sunmy2019 sunmy2019 added 3.14 bugs and security fixes needs backport to 3.14 bugs and security fixes 3.15 bugs and security fixes skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Apr 24, 2026
@bedevere-bot

bedevere-bot commented Apr 24, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sunmy2019 for commit 6d85124 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F148969%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 24, 2026
@sunmy2019 sunmy2019 removed 3.14 bugs and security fixes 3.15 bugs and security fixes labels Apr 24, 2026
skirpichev
skirpichev approved these changes Apr 24, 2026
View reviewed changes

@skirpichev skirpichev left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Apr 24, 2026
skirpichev
skirpichev reviewed Apr 25, 2026
View reviewed changes
Comment thread Modules/_ctypes/_ctypes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit f2c7c0d into python:main May 1, 2026
142 of 143 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented May 1, 2026

Copy link
Copy Markdown

Thanks @sunmy2019 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label May 1, 2026
@bedevere-app

bedevere-app Bot commented May 1, 2026

Copy link
Copy Markdown

GH-149224 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 1, 2026
encukou pushed a commit that referenced this pull request May 1, 2026
@miss-islington @sunmy2019
[3.14] gh-148967: Fix FFI type pointer handling for C complex support…
5ec845a 
… in set_stginfo_ffi_type_pointer (GH-148969) (GH-149224)

(cherry picked from commit f2c7c0d)

Co-authored-by: sunmy2019 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev approved these changes
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sunmy2019 @bedevere-bot @skirpichev @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.