GeezerVison

All commit authors signed the Contributor License Agreement.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Please, do not update your branch if there is no need to. Please read https://devguide.python.org/getting-started/pull-request-lifecycle/ before doing future contributions.

I have made the requested changes; please review again

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

Please let me know if there are any further suggestions or changes needed.

I have made the requested changes; please review again

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

Nothing to do on your side! Don't update your branch since there won't be a need to, I'll just wait a few days before alpha closes to merge this.

cc @sethmlarson @serhiy-storchaka @encukou

Sorry for being late to the party, but, IMO Morsel.js_output should be deprecated as well -- it has exactly the same issues.
(and BaseCookie uses that, so the warning should only be emitted there.)

Hey, quick question — should I include this change in the current PR, or would you prefer I open a separate PR specifically for the Morsel.js_output update?

I'd prefer here since they're so related.

I have made the requested changes; please review again.

As suggested by @encukou, I’ve deprecated Morsel.js_output(). The implementation now routes through Morsel.js_output(), so the deprecation warning is emitted only once.

Note on stacklevel:
The current implementation uses warnings._deprecated(), which has a fixed stacklevel=3. As a result, when BaseCookie.js_output() calls Morsel.js_output(), the warning points to BaseCookie.js_output() rather than the user's code. This could be improved by switching to warnings.warn() with a configurable stacklevel.
I'm happy to adjust this if preferred .

Thanks for making the requested changes!

@picnixz, @StanFromIreland, @serhiy-storchaka: please review the changes made to this pull request.

Documentation build overview

📚 cpython-previews | 🛠️ Build #32507822 | 📁 Comparing a91d066 against main (db0ee44)

  🔍 Preview build  

@serhiy-storchaka Thank you so much for the suggestion!
I've added Morsel._js_output() as a protected method containing the actual logic, so both Morsel.js_output() and BaseCookie.js_output() can warn independently and then delegate to _js_output(). This cleanly avoids multiple warnings and also fixes the stacklevel issue. I've also added cm.filename == file assertions to verify that the warning correctly points to the user's call site.