GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Deprecate BaseCookie.js_output() method · Issue #148849 · python/cpython

Deprecate BaseCookie.js_output() method #148849

New issue
Copy link
New issue
Copy link
Closed
#148978
Closed
Deprecate BaseCookie.js_output() method#148849
#148978
Copy link
Labels
stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directorytype-featureA feature request or enhancementA feature request or enhancement

Description

@sethmlarson
sethmlarson
opened on Apr 21, 2026
Issue body actions

This was recommended in #90309, and @serhiy-storchaka, @encukou, and I all concurred that this method should be deprecated as it's not used (according to searching GitHub) and likely was created when <script> support in browsers was not common which is no longer the case.

Linked PRs

  • gh-148849: Deprecate http.cookies.BaseCookie.js_output() #148978
Reacted by Stan Ulbrych and Bénédikt Tran

Activity

  1. StanFromIreland
    added this to Cookies issues 🍪on Apr 21, 2026
  2. StanFromIreland
    added
    type-featureA feature request or enhancementA feature request or enhancement
    stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory
    on Apr 21, 2026
  3. encukou commented on Apr 22, 2026

    @encukou
    encukou
    on Apr 22, 2026
    Member
    More actions

    IMO <script> support was common, but it was still common practice to include the “hiding” comment.
    <!-- begin hiding is still valid JS.

    I never concurred with the deprecation. What's the reason to remove this function again?

    Can we soft-deprecate it instead?

  4. serhiy-storchaka commented on Apr 22, 2026

    @serhiy-storchaka
    serhiy-storchaka
    on Apr 22, 2026
    Member
    More actions

    The problem is that it is almost not used, at least we have not find any examples in open sources. If we have no examples of use in real code, we cannot be sure that it works correctly. We cannot even be sure what is the purpose of it. We cannot maintain it.

  5. encukou commented on Apr 23, 2026

    @encukou
    encukou
    on Apr 23, 2026
    Member
    More actions

    OK, looking more into this, I see the function doesn't work correctly unless there's only one key/value pair.

    I withdraw my objection.

  6. encukou
    added
    easy
    on Apr 23, 2026
  7. mathaimp commented on Apr 25, 2026

    @mathaimp
    mathaimp
    on Apr 25, 2026
    More actions

    Can I work on this issue?

  8. kishorhange111
    added 2 commits that reference this issue on Apr 25, 2026

    pythongh-148849: Deprecate http.cookies.BaseCookie.js_output()

    f67449d

    Merge branch 'main' into pythongh-148849-deprecate-js-output

    25313d0
  9. picnixz
    removed
    easy
    on Apr 25, 2026
  10. kishorhange111
    added 4 commits that reference this issue on Apr 26, 2026

    Merge branch 'main' into pythongh-148849-deprecate-js-output

    1dcce83

    pythongh-148849: Deprecate Morsel.js_output()

    948a8f8

    pythongh-148849: Fix duplicate Morsel.js_output doc entry and indenta…

    c957098

    pythongh-148849: Add Morsel._js_output() to avoid multiple warnings

    a91d066
  11. serhiy-storchaka
    added a commit that references this issue on May 4, 2026

    gh-148849: Deprecate http.cookies.BaseCookie.js_output() (GH-148978)

    246fe14
  12. serhiy-storchaka
    closed this as completedin #148978on May 4, 2026
  13. github-project-automation
    moved this to Done in Cookies issues 🍪on May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directorytype-featureA feature request or enhancementA feature request or enhancement

    Projects

    • Cookies issues 🍪
      Status
      Done
      Show more project fields

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    You are visitor 01402503 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.