GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-148947: dataclasses: fix error on empty __class__ cell (GH-148948) by miss-islington · Pull Request #148995 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Apr 25, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Also add a test demonstrating the need for the existing "is oldcls" check.
(cherry picked from commit 6d7bbee)

Co-authored-by: Jelle Zijlstra [email protected]
Co-authored-by: Bartosz Sławecki [email protected]

  • Issue: dataclass(slots=True) fails if method has an empty __class__ cell #148947

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra @johnslavik @miss-islington
pythongh-148947: dataclasses: fix error on empty __class__ cell (pyth…
83fe2d3 
…onGH-148948)

Also add a test demonstrating the need for the existing "is oldcls" check.
(cherry picked from commit 6d7bbee)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Bartosz Sławecki <[email protected]>
@miss-islington
miss-islington requested a review from ericvsmith as a code owner April 25, 2026 15:31
@bedevere-app bedevere-app Bot mentioned this pull request Apr 25, 2026
gh-148947: dataclasses: fix error on empty __class__ cell #148948
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Apr 25, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Apr 25, 2026
dataclass(slots=True) fails if method has an empty __class__ cell #148947
Closed
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) April 25, 2026 15:31
@JelleZijlstra
JelleZijlstra merged commit 15e2b64 into python:3.14 Apr 25, 2026
50 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Apr 25, 2026
@miss-islington
miss-islington deleted the backport-6d7bbee-3.14 branch April 25, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.