GeezerVison

Copy link

Copy Markdown

Member

JelleZijlstra requested a review from ericvsmith as a code owner April 24, 2026 04:49

johnslavik approved these changes Apr 24, 2026

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

51 checks passed

JelleZijlstra deleted the weirdclass branch April 25, 2026 15:31

…on#148948)

Also add a test demonstrating the need for the existing "is oldcls" check.

Co-authored-by: Bartosz Sławecki <[email protected]>

…148948) (#148995)

gh-148947: dataclasses: fix error on empty __class__ cell  (GH-148948)

Also add a test demonstrating the need for the existing "is oldcls" check.
(cherry picked from commit 6d7bbee)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Bartosz Sławecki <[email protected]>

pythonGH-148948)

pythongh-148947: dataclasses: fix error on empty __class__ cell  (pythonGH-148948)

Also add a test demonstrating the need for the existing "is oldcls" check.
(cherry picked from commit 6d7bbee)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Bartosz Sławecki <[email protected]>
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

pythonGH-148948)

pythongh-148947: dataclasses: fix error on empty __class__ cell  (pythonGH-148948)

Also add a test demonstrating the need for the existing "is oldcls" check.
(cherry picked from commit 6d7bbee)

Consolidates the news entries given pythonGH-148947 bug was never present in the 3.13
branch

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Bartosz Sławecki <[email protected]>
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

…_delattr__ in frozen dataclasses with slots (GH-144021) (GH-148476)

gh-105936: Properly update closure cells for `__setattr__` and `__delattr__` in frozen dataclasses with slots (GH-144021)
(cherry picked from commit 8a398bf)

The cherry-pick required additional changes beyond the original commit
because 3.13 lacks the `__class__` closure cell fixup machinery that
was added in 3.14 by GH-124455 (gh-90562). Specifically:

- Backported `_update_func_cell_for__class__()` helper function and the
  closure fixup loop in `_add_slots()` from GH-124455. Without these,
  renaming the closure variable from `cls` to `__class__` has no effect
  because nothing updates the cell when the class is recreated with slots.
- Changed `_add_slots()` to use `newcls` instead of reusing `cls` for the
  recreated class, so both old and new class references are available for
  the fixup loop.
- Replaced `assertNotHasAttr` with `assertFalse(hasattr(...))` in tests
  (assertNotHasAttr was added in 3.14).
- Dropped `test_original_class_is_gced` additions (that test does not
  exist on 3.13; it was added by GH-137047 for gh-135228 which was not
  backported to 3.13).

gh-148947: dataclasses: fix error on empty __class__ cell  (GH-148948)

Also add a test demonstrating the need for the existing "is oldcls" check.
(cherry picked from commit 6d7bbee)

---------

Co-authored-by: Prometheus3375 <[email protected]>
Co-authored-by: Sviataslau <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Bartosz Sławecki <[email protected]>