GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-149225: Expose Py_CriticalSection in Stable ABI by encukou · Pull Request #149227 · python/cpython

Conversation

@encukou

@encukou encukou commented May 1, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Expose PyCriticalSection in Stable ABI #149225

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ngoldbaum reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@encukou
Expose Py_CriticalSection in Stable ABI
88be4b3
@encukou
encukou requested review from a team and ZeroIntensity as code owners May 1, 2026 12:47
@bedevere-app bedevere-app Bot added the awaiting core review label May 1, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 1, 2026
Expose PyCriticalSection in Stable ABI #149225
Closed
@encukou encukou added the release-blocker label May 1, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Release and Deferred blockers 🚫 May 1, 2026
@github-project-automation github-project-automation Bot added this to Release and Deferred blockers 🚫 May 1, 2026
@read-the-docs-community

read-the-docs-community Bot commented May 1, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32528039 | 📁 Comparing b289183 against main (f2c7c0d)

  🔍 Preview build  

43 files changed · ± 43 modified

± Modified

  • glossary.html
  • c-api/lifecycle.html
  • c-api/perfmaps.html
  • c-api/stable.html
  • c-api/synchronization.html
  • deprecations/index.html
  • deprecations/pending-removal-in-3.18.html
  • deprecations/pending-removal-in-3.19.html
  • deprecations/pending-removal-in-3.20.html
  • faq/programming.html
  • and 33 more...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Add blurb
d93282d
corona10
corona10 reviewed May 1, 2026
View reviewed changes
Comment thread Doc/c-api/synchronization.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Clarify the functions are no-ops in GIL builds
7fe42f4
@hugovk hugovk added the 3.15 bugs and security fixes label May 1, 2026
vstinner
vstinner approved these changes May 2, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread Include/critical_section.h Outdated
// Operations that need to lock two objects at once must use
// `Py_BEGIN_CRITICAL_SECTION2()`. You *CANNOT* use nested critical sections
// to lock more than one object at once, because the inner critical section
// may suspend the outer critical sections. This API does not provide a way

@vstinner vstinner May 2, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// may suspend the outer critical sections. This API does not provide a way
// may suspend the outer critical sections. This API does not provide a way

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/C_API/2026-05-01-14-49-09.gh-issue-149225.IdAYPZ.rst
@@ -0,0 +1,2 @@
:c:type:`PyCriticalSection` and related functions are added to the Stable
ABI.

@vstinner vstinner May 2, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you copy also this paragraph to What's New in Python 3.15 > C API changes > New features?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/c-api/synchronization.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 2, 2026
encukou added 3 commits May 4, 2026 14:47
@encukou
Whitespace fix
7098cb9
@encukou
What's New entry
c18af1b
@encukou
Merge in the main branch
9be8cb5
@encukou
encukou requested a review from AA-Turner as a code owner May 4, 2026 12:53
@vstinner

vstinner commented May 4, 2026

Copy link
Copy Markdown
Member

Tests / Windows / Build and test (x64, switch-case) (pull_request): Failing after 23m

Oh, the "FAIL: test_got_eof (test.test_ssl.ThreadedTests.test_got_eof)" failure is related to my recent OpenSSL 4 changes. I wrote #149366 to fix the test.
encukou reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Merge branch 'main' into critical-section-stable-abi-xs
b289183
@encukou
encukou merged commit 6ca5cdb into python:main May 4, 2026
98 of 102 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@github-project-automation github-project-automation Bot moved this from Todo to Done in Release and Deferred blockers 🚫 May 4, 2026
@bedevere-app bedevere-app Bot removed the awaiting merge label May 4, 2026
@encukou
encukou deleted the critical-section-stable-abi-xs branch May 4, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 left review comments
@vstinner vstinner vstinner approved these changes
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.15 bugs and security fixes release-blocker

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@encukou @vstinner @corona10 @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.