GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-148292: Remove shutdown() test in test_ssl.test_got_eof() by vstinner · Pull Request #149366 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 4, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

shutdown() behavior depends too much on the operating system and it's unrelated to the got_eof_error change.

  • Issue: 3.15.0a8 fails test_urllib2_localnet with OpenSSL 4.0.0beta1 #148292

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-148292: Remove shutdown() test in test_ssl.test_got_eof()
110e4ba 
shutdown() behavior depends too much on the operating system and it's
unrelated to the got_eof_error change.
@vstinner vstinner added the skip news label May 4, 2026
@vstinner
vstinner requested review from gpshead and picnixz as code owners May 4, 2026 13:48
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label May 4, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 4, 2026
3.15.0a8 fails test_urllib2_localnet with OpenSSL 4.0.0beta1 #148292
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 4, 2026
@vstinner

vstinner commented May 4, 2026

Copy link
Copy Markdown
Member Author

The test fails on the "Windows / Build and test (x64, switch-case)" CI: shutdown() fails with ECONNRESET instead of ENOTCONN.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request May 4, 2026
gh-149225: Expose Py_CriticalSection in Stable ABI #149227
Merged
@vstinner
vstinner enabled auto-merge (squash) May 4, 2026 13:51
@vstinner
vstinner merged commit 1e21cf6 into python:main May 4, 2026
55 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the openssl4_shutdown branch May 4, 2026 14:20
@bedevere-app bedevere-app Bot removed the awaiting core review label May 4, 2026
vstinner added a commit to vstinner/cpython that referenced this pull request May 13, 2026
@vstinner
pythongh-148292: Remove shutdown() test in test_ssl.test_got_eof() (p…
8191190 
…ython#149366)

The shutdown() behavior depends too much on the operating system and
it's unrelated to the got_eof_error change.

(cherry picked from commit 1e21cf6)
@xnox xnox mentioned this pull request Sep 12, 2026
Add support for OpenSSL 4.0.0 final #148600
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.