GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Skip GNU backtrace test on Arm 32-bit by diegorusso · Pull Request #149493 · python/cpython Conversation
|
|
!buildbot ARM Raspbian |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 3358e2d 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149493%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
still failing... |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
||
|
|
||
| def _gnu_backtrace_requires_unwind_tables(machine): | ||
| if not (sys.maxsize < 2**32 and machine.startswith("arm")): |
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
AFAIK it's an aarch64 machine, with a 32-bit Python build?
| if not (sys.maxsize < 2**32 and machine.startswith("arm")): | |
| if not (sys.maxsize < 2**32 and machine.startswith(("arm", "aarch"))): |
But we're deep into overfitting to Buildbot workers here :/
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
mmm I don't think this is the right approach. We need to base the condition about the build of Python
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
!buildbot ARM Raspbian |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @diegorusso for commit cb52a24 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149493%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| for option in options: | ||
| if option == "-funwind-tables": | ||
| unwind_tables = True | ||
| elif option == "-fno-unwind-tables": | ||
| unwind_tables = False | ||
| elif option == "-fasynchronous-unwind-tables": | ||
| asynchronous_unwind_tables = True | ||
| elif option == "-fno-asynchronous-unwind-tables": | ||
| asynchronous_unwind_tables = False | ||
| elif option == "-fexceptions": | ||
| exceptions = True | ||
| elif option == "-fno-exceptions": | ||
| exceptions = False |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of untested logic.
Should we skip the test for any 32-bit Arm?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I tend to agree with you. On Arm 32bit you can have unwind data with any of these flags: -funwind-tables, -fasynchronous-unwind-tables, -fexceptions
Sorry, something went wrong.
There was an error while loading. Please reload this page.
GNU backtrace() can return an empty stack on 32-bit Arm when the build lacks suitable runtime unwind tables. Rather than trying to infer the effective unwind-table compiler flags in the test, skip the GNU backtrace tests on all 32-bit Arm builds.
|
!buildbot ARM Raspbian |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @diegorusso for commit 61015e1 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149493%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
!buildbot ARM Raspbian |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Updating to fix some errors we introduced on the main branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
!buildbot ARM Raspbian |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @diegorusso for commit 42177ce 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149493%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and much simpler now
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks @diegorusso for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-149562 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.