GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-139489: Add is_valid_text to xml.__all__ by JelleZijlstra · Pull Request #149641 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 10, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add utility functions to test for legal XML characters and names #139489

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-139489: Add is_valid_text to xml.__all__
360d3b6
@JelleZijlstra
JelleZijlstra requested a review from serhiy-storchaka May 10, 2026 14:23
@JelleZijlstra JelleZijlstra added the needs backport to 3.15 bugs and security fixes label May 10, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 10, 2026
Add utility functions to test for legal XML characters and names #139489
Open
@bedevere-app bedevere-app Bot added the awaiting core review label May 10, 2026
JelleZijlstra
JelleZijlstra commented May 10, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-05-10-07-21-51.gh-issue-139489.rS7LTA.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Apply suggestion from @JelleZijlstra
42daf70
serhiy-storchaka
serhiy-storchaka approved these changes May 10, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 10, 2026
@JelleZijlstra
JelleZijlstra merged commit b45319e into python:main May 10, 2026
59 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented May 10, 2026

Copy link
Copy Markdown

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 10, 2026
@JelleZijlstra
JelleZijlstra deleted the isvalidtext branch May 10, 2026 20:44
@bedevere-app

bedevere-app Bot commented May 10, 2026

Copy link
Copy Markdown

GH-149652 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label May 10, 2026
JelleZijlstra added a commit that referenced this pull request May 10, 2026
@miss-islington @JelleZijlstra
[3.15] gh-139489: Add is_valid_text to xml.__all__ (GH-149641) (#149652)
1162834 
gh-139489: Add is_valid_text to xml.__all__ (GH-149641)
(cherry picked from commit b45319e)

Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.