GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-149571: Fix the C implementation of Element.itertext() by serhiy-storchaka · Pull Request #149929 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 16, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It no longer emits text for comments and processing instructions.

  • Issue: Element.itertext() works differently in C and Python implementations #149571

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CharlieJamesGwapo reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@serhiy-storchaka
pythongh-149571: Fix the C implementation of Element.itertext()
e632480 
It no longer emits text for comments and processing instructions.
@serhiy-storchaka
serhiy-storchaka requested a review from scoder May 16, 2026 23:27
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels May 16, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 16, 2026
Element.itertext() works differently in C and Python implementations #149571
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 16, 2026
@serhiy-storchaka
serhiy-storchaka merged commit 7de4fcd into python:main May 27, 2026
63 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented May 27, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label May 27, 2026
@serhiy-storchaka
serhiy-storchaka deleted the etree-itertext-comment branch May 27, 2026 10:23
@bedevere-app

bedevere-app Bot commented May 27, 2026

Copy link
Copy Markdown

GH-150509 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label May 27, 2026
@bedevere-app

bedevere-app Bot commented May 27, 2026

Copy link
Copy Markdown

GH-150510 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 27, 2026
@bedevere-app

bedevere-app Bot commented May 27, 2026

Copy link
Copy Markdown

GH-150511 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 27, 2026
serhiy-storchaka added a commit that referenced this pull request May 27, 2026
@miss-islington @serhiy-storchaka
[3.13] gh-149571: Fix the C implementation of Element.itertext() (GH-…
98a9ccb 
…149929) (GH-150511)

It no longer emits text for comments and processing instructions.
(cherry picked from commit 7de4fcd)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request May 27, 2026
@miss-islington @serhiy-storchaka
[3.14] gh-149571: Fix the C implementation of Element.itertext() (GH-…
27a18eb 
…149929) (GH-150510)

It no longer emits text for comments and processing instructions.
(cherry picked from commit 7de4fcd)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request May 27, 2026
@miss-islington @serhiy-storchaka
[3.15] gh-149571: Fix the C implementation of Element.itertext() (GH-…
d2b10e7 
…149929) (GH-150509)

It no longer emits text for comments and processing instructions.
(cherry picked from commit 7de4fcd)

Co-authored-by: Serhiy Storchaka <[email protected]>
@ines-besrour ines-besrour mentioned this pull request Nov 11, 2026
ElementTree: itertext() and tostring(method="text") lose the text of elements whose tag is a QName #161809
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scoder scoder Awaiting requested review from scoder

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.