GeezerVison

On "AMD64 Alpine Linux NoGIL 3.x" buildbot, currently test_threading.test_recursion_limit() does crash with a stack overflow: issue gh-148260.

With this change, Python is built with -Wl,-z,stack-size=1048576 linker flag and so uses a thread stack size of 1 MiB by default, instead of musl default which is 128 kiB.

With this change, test_threading.test_recursion_limit() does pass. I tested Python built in debug mode (gcc -O3) and release mode (gcc -Og), with and without the GIL (--disable-gil). The buildbot worker uses ./configure --with-pydebug --disable-gil.

@corona10 @erlend-aasland @picnixz: I'm looking for autotools experts to review my configure.ac change. I'm not comfortable with changing the build system.

Currently, the ./configure script doesn't run a built C program, it only uses AC_LINK_IFELSE or AC_COMPILE_IFELSE to check if a C program can be built or linked.

It seems like running a program is the only way to check if Python is linked to the musl library. My change is not specific to the musl library, but instead read the default thread stack size to decide if -Wl,-z,stack-size=1048576 linker flag should be used.

My configure.ac is inspired by Python 3.12 ./configure script which runs $CPP $CPPFLAGS conftest.c >conftest.out to read the output of the C preprocessor. But my change is different since it compiles a C program and then runs the C program. The code is skipped if Python is cross-compiled.

!buildbot Alpine

🤖 New build scheduled with the buildbot fleet by @zware for commit fd078ac 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149993%2Fmerge

The command will test the builders whose names match following regular expression: Alpine

The builders matched are:

• AMD64 Alpine Linux PR
• AMD64 Alpine Linux NoGIL PR

Cool, the test suite passed on Alpine Linux buildbots:

buildbot/AMD64 Alpine Linux NoGIL PR — Build done.
buildbot/AMD64 Alpine Linux PR — Build done.

!buildbot Alpine

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 86027a6 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149993%2Fmerge

The command will test the builders whose names match following regular expression: Alpine

The builders matched are:

• AMD64 Alpine Linux PR
• AMD64 Alpine Linux NoGIL PR

buildbot Alpine

The worker is down at the moment; I had a storm-related power outage this morning and my UPS has not yet recharged enough to turn the host back on. It will be back by this afternoon.

buildbot/AMD64 Alpine Linux NoGIL PR
buildbot/AMD64 Alpine Linux PR

It works as expected:

• configure log: checking for thread stack size... 1048576.
• compile log: gcc -shared -Wl,-z,stack-size=1048576 Modules/arraymodule.o -o Modules/array.cpython-316td-x86_64-linux-musl.so
• tests: test_threading passed

On "AMD64 Alpine Linux NoGIL PR", test_threading crashed :-( But it passed when rerun...

0:03:47 load avg: 6.33 [255/505/1] test_threading worker non-zero exit code (Exit code -11 (SIGSEGV)) -- running (1): test_compileall (30.8 sec)

(...)
test_start_thread_again (test.test_threading.ThreadingExceptionTests.test_start_thread_again) ... ok
test_concurrent_tee_negative_n (test.test_threading.ThreadingIteratorToolsTests.test_concurrent_tee_negative_n) ... ok
test_concurrent_tee_supports_concurrent_consumers (test.test_threading.ThreadingIteratorToolsTests.test_concurrent_tee_supports_concurrent_consumers) ...
(...)
0:08:02 load avg: 3.48 Run 1 test in parallel using 1 worker process (timeout: 30 min, worker timeout: 35 min)
0:08:26 load avg: 2.66 [1/1] test_threading passed
(...)

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

GH-150150 is a backport of this pull request to the 3.15 branch.

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

GH-151586 is a backport of this pull request to the 3.14 branch.