GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-150178: Fix refcount leaks in hamt allocation failure paths by lpyu001 · Pull Request #150179 · python/cpython

Conversation

@lpyu001

@lpyu001 lpyu001 commented May 21, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

fix:#150178

  • Issue: hamt.c: sub_node leaked in bitmap_assoc and bitmap_without #150178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lpyu001
Fix refcount leaks in hamt allocation failure paths
4a01fa0
@lpyu001
lpyu001 requested a review from 1st1 as a code owner May 21, 2026 08:04
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2026
hamt.c: sub_node leaked in bitmap_assoc and bitmap_without #150178
Closed
@bedevere-app bedevere-app Bot added the awaiting review label May 21, 2026
@picnixz picnixz changed the title gh-150178:Fix refcount leaks in hamt allocation failure paths gh-150178: Fix refcount leaks in hamt allocation failure paths May 21, 2026
@aisk

aisk commented May 21, 2026

Copy link
Copy Markdown
Member

The fix looks good to me. However, I think the NEWS entry is too internal-facing, and it's a rare-case fix, so I don't think we need a NEWS entry for it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aisk aisk added the skip news label May 21, 2026
@lpyu001
delete NEWS
1589a15
@lpyu001

lpyu001 commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

The fix looks good to me. However, I think the NEWS entry is too internal-facing, and it's a rare-case fix, so I don't think we need a NEWS entry for it.

thanks for your comments, I've delete NEWS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aisk
aisk approved these changes May 21, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels May 21, 2026
kumaraditya303
kumaraditya303 approved these changes May 23, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 23, 2026
@kumaraditya303
kumaraditya303 merged commit 32823af into python:main May 23, 2026
60 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 23, 2026
@kumaraditya303 kumaraditya303 added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels May 23, 2026
@miss-islington-app

miss-islington-app Bot commented May 23, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented May 23, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented May 23, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented May 23, 2026

Copy link
Copy Markdown

GH-150301 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 23, 2026
kumaraditya303 pushed a commit that referenced this pull request May 23, 2026
@miss-islington @lpyu001
[3.13] gh-150178: Fix refcount leaks in hamt allocation failure paths (…
95c9323 
…GH-150179) (#150301)

gh-150178: Fix refcount leaks in hamt allocation failure paths (GH-150179)
(cherry picked from commit 32823af)

Co-authored-by: pengyu lee <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request May 23, 2026
@miss-islington @lpyu001
[3.15] gh-150178: Fix refcount leaks in hamt allocation failure paths (…
6b17d1a 
…GH-150179) (#150303)

gh-150178: Fix refcount leaks in hamt allocation failure paths (GH-150179)
(cherry picked from commit 32823af)

Co-authored-by: pengyu lee <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request May 24, 2026
@miss-islington @lpyu001
[3.14] gh-150178: Fix refcount leaks in hamt allocation failure paths (…
5676bfc 
…GH-150179) (#150302)

gh-150178: Fix refcount leaks in hamt allocation failure paths (GH-150179)
(cherry picked from commit 32823af)

Co-authored-by: pengyu lee <[email protected]>
@StanFromIreland StanFromIreland mentioned this pull request Jul 3, 2026
PR incorrectly classifed as still needing backports (w/ labels) hugovk/dashboard#23
Open
@StanFromIreland StanFromIreland removed the needs backport to 3.14 bugs and security fixes label Jul 3, 2026
@StanFromIreland StanFromIreland removed the needs backport to 3.15 bugs and security fixes label Jul 3, 2026
@lpyu001
lpyu001 deleted the hamt branch September 23, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lpyu001 @aisk @kumaraditya303 @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.