GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] Replace deprecated action with RtD app (GH-149111) by miss-islington · Pull Request #150233 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 22, 2026

Copy link
Copy Markdown
Contributor

(cherry picked from commit 933e2dd)

Co-authored-by: Hugo van Kemenade [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hugovk @miss-islington
Replace deprecated action with RtD app (pythonGH-149111)
ce0c37f
(cherry picked from commit 933e2dd)

Co-authored-by: Hugo van Kemenade <[email protected]>
@miss-islington
miss-islington requested review from ezio-melotti and hugovk as code owners May 22, 2026 10:46
@bedevere-app bedevere-app Bot mentioned this pull request May 22, 2026
Replace deprecated action with RtD app #149111
Merged
@bedevere-app bedevere-app Bot added skip issue skip news awaiting review labels May 22, 2026
@hugovk
hugovk enabled auto-merge (squash) May 22, 2026 10:47
@hugovk

hugovk commented May 22, 2026

Copy link
Copy Markdown
Member

Lint CI is failing:

Error: The action actions/cache@v4 is not allowed in python/cpython because all actions must be pinned to a full-length commit SHA.

That's because two days we checked "[x] Require actions to be pinned to a full-length commit SHA" in the repo settings.

I'll pin the actions here and in older branches, like in the newer branches.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented May 22, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We already hash-pin our actions, the unpinned actions/cache is coming from pre-commit/action:

Download action repository 'pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd' (SHA:2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd)

https://github.com/pre-commit/action/blob/1b06ec171f2f6faa71ed760c4042bd969e4f8b43/action.yml#L15

They've repeatedly rejected pinning it, suggesting forking instead:

  • Pin action to a commit sha pre-commit/action#177
  • Pin actions/cache to SHA pre-commit/action#230
  • Pin actions/cache pre-commit/action#231
  • Pin actions/cache to a full-length commit SHA pre-commit/action#232
  • Pin actions/cache to commit SHA for better security pre-commit/action#236

We've already switched to j178/prek-action in the newer branches, let's backport that.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk
Replace actions/setup-python with j178/prek-action due to unpinned ac…
1885ad0
…tions/cache
@read-the-docs-community

read-the-docs-community Bot commented May 22, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32809114 | 📁 Comparing 1885ad0 against main (28eac9a)

  🔍 Preview build  

534 files changed · + 3 added · ± 477 modified · - 54 deleted

+ Added

  • c-api/objbuffer.html
  • library/2to3.html
  • library/tkinter.tix.html

± Modified

  • about.html
  • bugs.html
  • copyright.html
  • glossary.html
  • index.html
  • license.html
  • py-modindex.html
  • c-api/abstract.html
  • c-api/allocation.html
  • c-api/apiabiversion.html
  • and 467 more...

- Deleted

  • 404.html
  • improve-page-nojs.html
  • improve-page.html
  • _static/tachyon-example-flamegraph.html
  • _static/tachyon-example-heatmap.html
  • c-api/curses.html
  • c-api/extension-modules.html
  • c-api/interp-lifecycle.html
  • c-api/lifecycle.html
  • c-api/monitoring.html
  • and 44 more...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk mentioned this pull request May 22, 2026
[3.11] Replace pre-commit/action with j178/prek-action #150237
Merged
@hugovk
hugovk merged commit ae9ebe4 into python:3.12 May 22, 2026
26 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label May 22, 2026
@miss-islington
miss-islington deleted the backport-933e2dd-3.12 branch May 22, 2026 11:23
@hugovk hugovk added the needs backport to 3.11 only security fixes label Jun 18, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 18, 2026

Copy link
Copy Markdown

Thanks @miss-islington for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Jun 18, 2026

Copy link
Copy Markdown

Sorry, @miss-islington and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ae9ebe4839ac9a9d19ce7ff1fc8edace42efb7e1 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app miss-islington-app Bot assigned hugovk Jun 18, 2026
@bedevere-app

bedevere-app Bot commented Jun 18, 2026

Copy link
Copy Markdown

GH-151657 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jun 18, 2026
hugovk added a commit that referenced this pull request Jun 18, 2026
@hugovk @miss-islington
[3.11] Replace deprecated action with RtD app (GH-149111) (GH-150233) (…
79f6614
…#151657)

Co-authored-by: Miss Islington (bot) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.