GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-151177: Fix race condition in `_testembed` by ZeroIntensity · Pull Request #151293 · python/cpython

Conversation

@ZeroIntensity

@ZeroIntensity ZeroIntensity commented Jun 11, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The interpreter guard needs to be released after the flag has been set, not before. Otherwise, the main thread will be unblocked and can potentially read the done flag before the thread has a chance to set it.

  • Issue: test_thread_state_ensure is flaky on Fedora Linux s390x #151177

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZeroIntensity
Fix race condition in _testembed
891a74e
@ZeroIntensity ZeroIntensity added tests Tests in the Lib/test dir skip news needs backport to 3.15 bugs and security fixes labels Jun 11, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 11, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 11, 2026
test_thread_state_ensure is flaky on Fedora Linux s390x #151177
Closed
@ZeroIntensity
ZeroIntensity requested a review from encukou June 11, 2026 02:36
@ZeroIntensity

ZeroIntensity commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

!buildbot s390x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 11, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit 891a74e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F151293%2Fmerge

The command will test the builders whose names match following regular expression: s390x

The builders matched are:

  • s390x RHEL8 LTO + PGO PR
  • s390x Fedora Stable Clang PR
  • s390x Fedora Rawhide PR
  • s390x Fedora Stable Refleaks PR
  • s390x Fedora Rawhide LTO + PGO PR
  • s390x Fedora Rawhide NoGIL PR
  • s390x Fedora Stable Clang Installed PR
  • s390x RHEL8 Refleaks PR
  • s390x Fedora Stable LTO + PGO PR
  • s390x Fedora Stable LTO PR
  • s390x RHEL9 Refleaks PR
  • s390x Fedora Rawhide Refleaks PR
  • s390x RHEL9 PR
  • s390x Fedora Rawhide Clang Installed PR
  • s390x RHEL9 LTO + PGO PR
  • s390x Fedora Rawhide NoGIL refleaks PR
  • s390x RHEL9 LTO PR
  • s390x Fedora Rawhide Clang PR
  • s390x RHEL8 PR
  • s390x RHEL8 LTO PR
  • s390x Fedora Rawhide LTO PR
  • s390x Fedora Stable PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit f9ffca3 into python:main Jun 11, 2026
81 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 11, 2026
@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151312 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jun 11, 2026
ZeroIntensity added a commit that referenced this pull request Jun 11, 2026
@miss-islington @ZeroIntensity
[3.15] gh-151177: Fix race condition in _testembed (GH-151293) (GH-…
491768d 
…151312)

gh-151177: Fix race condition in `_testembed` (GH-151293)
(cherry picked from commit f9ffca3)

Co-authored-by: Peter Bierma <[email protected]>
@ZeroIntensity
ZeroIntensity deleted the fix-testembed branch June 11, 2026 12:25
philthompson10 pushed a commit to philthompson10/cpython that referenced this pull request Jun 17, 2026
@ZeroIntensity @philthompson10
pythongh-151177: Fix race condition in _testembed (pythonGH-151293)
a406230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ZeroIntensity @bedevere-bot @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.