GeezerVison is showing github.com — gh-146102: Fix type slot_bf_getbuffer() error handling by vstinner · Pull Request #151346 · python/cpython
Conversation
vstinner
commented
Jun 11, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Call PyBuffer_Release() if PyObject_GC_New() fails.
Fix also bytes_join(): only call Py_DECREF(item) after formatting the error message which uses item.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Call PyBuffer_Release() if PyObject_GC_New() fails.
Fix also bytes_join(): only call Py_DECREF(item) after formatting the
error message which uses item.
Tests / Windows / Build and test (x64, tail-call) (pull_request): Failing after 10m
It's a test_logging test which fails randomly: I reported the bug to issue gh-84649.
FAIL: test_rollover_at_midnight (test.test_logging.TimedRotatingFileHandlerTest.test_rollover_at_midnight)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
philthompson10
pushed a commit
to philthompson10/cpython
that referenced
this pull request
Jun 17, 2026
…151346)
Call PyBuffer_Release() if PyObject_GC_New() fails.
Fix also bytes_join(): only call Py_DECREF(item) after formatting the
error message which uses item.
Reviewers
cmaloney
cmaloney approved these changes
markshannon
Awaiting requested review from markshannon
markshannon is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.