GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146102: Don't clear exception on success in odictobject.c by vstinner · Pull Request #151347 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 11, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Calling PyErr_Clear() on success can mask a pending exception. Replace it with an assertion checking that no exception is set.

  • Issue: Umbrella issue: bugs found using cpython-review-toolkit #146102

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-146102: Don't clear exception on success in odictobject.c
29ab5d8 
Calling PyErr_Clear() on success can mask a pending exception.
Replace it with an assertion checking that no exception is set.
@vstinner vstinner added the skip news label Jun 11, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 11, 2026
@vstinner

vstinner commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

See the report: https://gist.github.com/devdanzin/9015c335e324a94ea06932bdd643a7dc.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Jun 11, 2026
Umbrella issue: bugs found using cpython-review-toolkit #146102
Open
serhiy-storchaka
serhiy-storchaka approved these changes Jun 13, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 13, 2026
@vstinner
vstinner merged commit b3b7c00 into python:main Jun 15, 2026
59 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the odict branch June 15, 2026 09:46
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 15, 2026
philthompson10 pushed a commit to philthompson10/cpython that referenced this pull request Jun 17, 2026
@vstinner @philthompson10
pythongh-146102: Don't clear exception on success in odictobject.c (p…
8cd462e 
…ython#151347)

Calling PyErr_Clear() on success can mask a pending exception.
Replace it with an assertion checking that no exception is set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.