GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-32912: Revert warnings for invalid escape sequences. by serhiy-storchaka · Pull Request #15142 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 6, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

DeprecationWarning will continue to be emitted for invalid
escape sequences in string and bytes literals in 3.8.
SyntaxWarning will be emitted in 3.9.

https://bugs.python.org/issue32912

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-32912: Revert warnings for invalid escape sequences.
5d4c998 
DeprecationWarning will continue to be emitted for invalid
escape sequences in string and bytes literals in 3.8.
SyntaxWarning will be emitted in 3.9.
@serhiy-storchaka
serhiy-storchaka requested a review from rhettinger August 6, 2019 11:10
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 6, 2019
@bedevere-bot bedevere-bot added the awaiting core review label Aug 6, 2019
jdemeyer
jdemeyer reviewed Aug 6, 2019
View reviewed changes
Comment thread Doc/reference/lexical_analysis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@asmeurer asmeurer mentioned this pull request Aug 6, 2019
Modify comparisons to adhere to Python 3.8 guidelines sympy/sympy#16986
Merged
@serhiy-storchaka
Fix a typo.
1775d3f
@hugovk hugovk mentioned this pull request Aug 7, 2019
Avoid DeprecationWarning due to invalid escapes in docstrings jazzband/tablib#365
Merged
rhettinger
rhettinger approved these changes Aug 8, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 8, 2019
@gpshead
update the wording to not promise 3.9
3f58e3f 
and mention that SyntaxError will happen after SyntaxWarning.  we're being non-specific on purpose here as we haven't worked out the plan to make this happen without causing end user pain yet.  right now most code owners do not see the DeprecationWarning but when turned into a SyntaxWarning, _users_ of libraries see it more often than owners.  So it is a negative experience all around.
gpshead
gpshead approved these changes Aug 8, 2019
View reviewed changes
@gpshead

gpshead commented Aug 8, 2019

Copy link
Copy Markdown
Member

My only problem with this PR is only that it is being done on the 3.8 branch.

We should revert this on the master (future 3.9) branch as well. We clearly aren't ready to commit to doing this in 3.9 either so lets redo this on top of that and apply the "needs backport to 3.8" label.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CuriousLearner
CuriousLearner approved these changes Aug 9, 2019
View reviewed changes

@CuriousLearner CuriousLearner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree with @gpshead on applying this to master and then backporting to 3.8

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
gpshead merged commit 4c5b6ba into python:3.8 Aug 9, 2019
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 9, 2019
@gpshead

gpshead commented Aug 9, 2019

Copy link
Copy Markdown
Member

merged. I'll just reapply an equivalent to master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead mentioned this pull request Aug 9, 2019
bpo-32912: Revert SyntaxWarning on invalid escape sequences. #15195
Merged
miss-islington pushed a commit that referenced this pull request Aug 10, 2019
@gpshead @miss-islington
bpo-32912: Revert SyntaxWarning on invalid escape sequences. (GH-15195)
b4be87a 
DeprecationWarning will continue to be emitted for invalid escape
sequences in string and bytes literals just as it did in 3.7.

SyntaxWarning may be emitted in the future. But per mailing list
discussion, we don't yet know when because we haven't settled on how to
do so in a non-disruptive manner.

(Applies 4c5b6ba to the master branch).
(This is #15142 for master/3.9)


https://bugs.python.org/issue32912



Automerge-Triggered-By: @gpshead
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@gpshead @lisroach
bpo-32912: Revert SyntaxWarning on invalid escape sequences. (pythonG…
06d50ad 
…H-15195)

DeprecationWarning will continue to be emitted for invalid escape
sequences in string and bytes literals just as it did in 3.7.

SyntaxWarning may be emitted in the future. But per mailing list
discussion, we don't yet know when because we haven't settled on how to
do so in a non-disruptive manner.

(Applies 4c5b6ba to the master branch).
(This is python#15142 for master/3.9)


https://bugs.python.org/issue32912



Automerge-Triggered-By: @gpshead
@serhiy-storchaka
serhiy-storchaka deleted the revert-bpo-32912-3.8 branch October 7, 2019 17:03
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@gpshead @DinoV
bpo-32912: Revert SyntaxWarning on invalid escape sequences. (pythonG…
cc99254 
…H-15195)

DeprecationWarning will continue to be emitted for invalid escape
sequences in string and bytes literals just as it did in 3.7.

SyntaxWarning may be emitted in the future. But per mailing list
discussion, we don't yet know when because we haven't settled on how to
do so in a non-disruptive manner.

(Applies 4c5b6ba to the master branch).
(This is python#15142 for master/3.9)


https://bugs.python.org/issue32912



Automerge-Triggered-By: @gpshead
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@gpshead @websurfer5
bpo-32912: Revert SyntaxWarning on invalid escape sequences. (pythonG…
73140c6 
…H-15195)

DeprecationWarning will continue to be emitted for invalid escape
sequences in string and bytes literals just as it did in 3.7.

SyntaxWarning may be emitted in the future. But per mailing list
discussion, we don't yet know when because we haven't settled on how to
do so in a non-disruptive manner.

(Applies 4c5b6ba to the master branch).
(This is python#15142 for master/3.9)


https://bugs.python.org/issue32912



Automerge-Triggered-By: @gpshead
@Vgr255 Vgr255 mannequin mentioned this pull request Nov 2, 2022
Raise non-silent warning for invalid escape sequences #77093
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdemeyer jdemeyer jdemeyer left review comments
@gpshead gpshead gpshead approved these changes
@rhettinger rhettinger rhettinger approved these changes
@CuriousLearner CuriousLearner CuriousLearner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@serhiy-storchaka @gpshead @rhettinger @jdemeyer @CuriousLearner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.