GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146102：Fix cross-interpreter NotShareableError ref handling by lpyu001 · Pull Request #151578 · python/cpython

Conversation

@lpyu001

@lpyu001 lpyu001 commented Jun 17, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This fixes two ownership issues:

  • _ensure_notshareableerror() now returns immediately when the current raised exception is already a NotShareableError. The function had restored ctx to the thread state but then continued using it, even though ownership had been handed back.
  • _PyXI_UnwrapNotShareableError() now decrefs the exception taken from the thread state if _PyXI_InitFailure() fails, avoiding a leaked exception reference on that error path.

The _pop_preserved() shadowed-variable leak is already fixed on this branch, so this PR does not touch it.

glist：https://gist.github.com/devdanzin/a56b8cb579b1950b4206e8a42d6be650

  • Issue: Umbrella issue: bugs found using cpython-review-toolkit #146102

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lpyu001
Fix cross-interpreter NotShareableError ref handling
fcf7a5f
@lpyu001
lpyu001 requested a review from ericsnowcurrently as a code owner June 17, 2026 06:44
@bedevere-app bedevere-app Bot added the awaiting review label Jun 17, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 17, 2026
Umbrella issue: bugs found using cpython-review-toolkit #146102
Open
@lpyu001
Merge branch 'main' into fix-crossinterp.c-bug2
bd78431
@lpyu001 lpyu001 mentioned this pull request Jul 23, 2026
gh-153664: Fix reference leaks in cross-interpreter NotShareableError handling #153665
Closed
@aisk

aisk commented Jul 23, 2026

Copy link
Copy Markdown
Member

Since this is a user facing bug, could you add a simple NEWS entry, like the one in #153665?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpyu001

lpyu001 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Since this is a user facing bug, could you add a simple NEWS entry, like the one in #153665?

of course
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpyu001
pythongh-151578: Add NotShareableError NEWS entry
8c1af74
@github-actions

github-actions Bot commented Oct 28, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lpyu001 @aisk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.