GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-151126: Add missing `PyErr_NoMemory` in `_winapi.c` by IvyXu420 · Pull Request #151588 · python/cpython

Conversation

@IvyXu420

@IvyXu420 IvyXu420 commented Jun 17, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Follows-up to #151154

  • Issue: Many places have missing PyErr_NoMemory() call after failing memory allocation #151126

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@IvyXu420
Fix missing PyErr_NoMemory in _winapi.c
01a85ec
@bedevere-app bedevere-app Bot added the awaiting review label Jun 17, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 17, 2026
Many places have missing PyErr_NoMemory() call after failing memory allocation #151126
Open
sobolevn
sobolevn reviewed Jun 25, 2026
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@IvyXu420
Address review
59215a7
sobolevn
sobolevn approved these changes Jun 25, 2026
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 25, 2026
@sobolevn
Update Modules/_winapi.c
5782830
@sobolevn
sobolevn enabled auto-merge (squash) June 25, 2026 10:21
@sobolevn sobolevn added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jun 25, 2026
@sobolevn
sobolevn merged commit a580029 into python:main Jun 25, 2026
60 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

Thanks @ByteFlowing1337 for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 25, 2026
@bedevere-app

bedevere-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

GH-152182 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jun 25, 2026
@bedevere-app

bedevere-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

GH-152183 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 25, 2026
@bedevere-app

bedevere-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

GH-152184 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 25, 2026
@IvyXu420
IvyXu420 deleted the fix-151126-winapi branch June 25, 2026 10:52
sobolevn added a commit that referenced this pull request Jun 25, 2026
@miss-islington @IvyXu420 @sobolevn
[3.13] gh-151126: Add missing PyErr_NoMemory in _winapi.c (GH-151588
8feedcc 
) (#152184)

gh-151126: Add missing `PyErr_NoMemory` in `_winapi.c` (GH-151588)
(cherry picked from commit a580029)

Co-authored-by: Ivy Xu <[email protected]>
Co-authored-by: sobolevn <[email protected]>
sobolevn added a commit that referenced this pull request Jun 25, 2026
@miss-islington @IvyXu420 @sobolevn
[3.14] gh-151126: Add missing PyErr_NoMemory in _winapi.c (GH-151588
b51f606 
) (#152183)

gh-151126: Add missing `PyErr_NoMemory` in `_winapi.c` (GH-151588)
(cherry picked from commit a580029)

Co-authored-by: Ivy Xu <[email protected]>
Co-authored-by: sobolevn <[email protected]>
sobolevn added a commit that referenced this pull request Jun 25, 2026
@miss-islington @IvyXu420 @sobolevn
[3.15] gh-151126: Add missing PyErr_NoMemory in _winapi.c (GH-151588
d6fd537 
) (#152182)

gh-151126: Add missing `PyErr_NoMemory` in `_winapi.c` (GH-151588)
(cherry picked from commit a580029)

Co-authored-by: Ivy Xu <[email protected]>
Co-authored-by: sobolevn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@IvyXu420 @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.