GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145177: Bump Emscripten to 6.0.0 by hoodmane · Pull Request #151611 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Jun 17, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

And fix two problems due to changes in Emscripten libc:

  1. There was a regression in getentropy that broke it if exactly one byte is requested. Replace it with a wrapped getentropy that replaces a one byte request with a two-byte request and then put the first byte in the original buffer.
  2. Emscripten libc now supports umask. We need to initialize the emscripten libc umask to the ambient umask and zero out the ambient umask.
  • Issue: Emscripten buildbot: Support multiple Emscripten versions #145177

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
hoodmane requested review from AA-Turner, corona10, emmatyping, erlend-aasland, freakboy3742 and itamaro as code owners June 17, 2026 20:36
@bedevere-app bedevere-app Bot mentioned this pull request Jun 17, 2026
Emscripten buildbot: Support multiple Emscripten versions #145177
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jun 17, 2026
@hoodmane hoodmane added skip news OS-emscripten needs backport to 3.15 bugs and security fixes and removed awaiting review labels Jun 17, 2026
@hoodmane
hoodmane force-pushed the emscripten-6.0.0-2 branch from 3a9f69b to 2ea82b6 Compare June 17, 2026 23:12
@freakboy3742

freakboy3742 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

These changes all makes sense; my only hesitation on merging is establishing exactly the policy is on backports (cf this thread).
hoodmane reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane hoodmane removed the needs backport to 3.15 bugs and security fixes label Jun 18, 2026
@hoodmane
pythongh-145177: Bump Emscripten to 6.0.0
483b437 
And fix two problems due to changes in Emscripten libc:

1. There was a regression in getentropy that broke it if exactly one byte is
requested. Replace it with a wrapped getentropy that replaces a one byte request
with a two-byte request and then put the first byte in the original buffer.
2. Emscripten libc now supports umask. We need to initialize the emscripten
libc umask to the ambient umask and zero out the ambient umask.
@hoodmane
hoodmane force-pushed the emscripten-6.0.0-2 branch from 2ea82b6 to 483b437 Compare June 18, 2026 17:39
@hoodmane

hoodmane commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

@freakboy3742 I removed the needs-backport label, can we merge this to main and we can figure out whether or not it gets a backport later?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
freakboy3742
freakboy3742 approved these changes Jun 18, 2026
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - that makes sense.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting merge label Jun 18, 2026
@freakboy3742
freakboy3742 merged commit d701f8e into python:main Jun 18, 2026
180 of 186 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 18, 2026
@hoodmane
hoodmane deleted the emscripten-6.0.0-2 branch June 19, 2026 03:12
pyctrl pushed a commit to pyctrl/cpython that referenced this pull request Jul 5, 2026
@hoodmane @pyctrl
pythongh-145177: Bump Emscripten to 6.0.0 (python#151611)
c374bc6 
Bumps Emscripten to 6.0.0, and fixes related issues in getentropy() and umask().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hoodmane @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.