GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-151669: Normalize symlink targets in tarfile.TarFile.gettarinfo() by dnicolodi · Pull Request #151671 · python/cpython

Conversation

@dnicolodi

@dnicolodi dnicolodi commented Jun 18, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This applies a normalization complementary to the one added to tarfile.TarFile.extract() in gh-138309.

  • Issue: tarfile.TarFile.add() does not normalize symlink targets on Windows #151669

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dnicolodi
pythongh-151669: Normalize symlink targets in tarfile.TarFile.gettari…
b05605c 
…nfo()

This applies a normalization complementary to the one added to
tarfile.TarFile.extract() in pythongh-138309.
@dnicolodi
dnicolodi requested a review from ethanfurman as a code owner June 18, 2026 19:58
@python-cla-bot

python-cla-bot Bot commented Jun 18, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Jun 18, 2026
tarfile.TarFile.add() does not normalize symlink targets on Windows #151669
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jun 18, 2026
@dnicolodi

dnicolodi commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

I think this change should be mentioned in NEWS next to the one to extract(). However, I don't know how amending exiting entries in NEWS is handled.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dnicolodi dnicolodi mentioned this pull request Jun 19, 2026
meson dist results in invalid tar archives on Windows when the repository contains symlinks mesonbuild/meson#15932
Closed
@bonzini

bonzini commented Jun 19, 2026

Copy link
Copy Markdown

According to the CI message, the news entry should be added to Misc/NEWS.d/next
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dnicolodi

dnicolodi commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

According to the CI message, the news entry should be added to Misc/NEWS.d/next

I understand this, but in this case I think the best would be to extend the NEWS entry added by gh-138309, and I don't know what is the policy for doing this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ngoldbaum ngoldbaum added the skip news label Jun 23, 2026
@ngoldbaum

ngoldbaum commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Ping @encukou - @mgorny tells me this PR is needed by meson to add Python 3.15 and abi3t support.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ngoldbaum ngoldbaum removed the skip news label Jun 23, 2026
@rgommers rgommers mentioned this pull request Jun 24, 2026
CI: add Python 3.15 mesonbuild/meson-python#855
Merged
@ngoldbaum

ngoldbaum commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@hugovk can you help clarify how the news entry should be handled here? Should @dnicolodi simply add a new one?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Jun 24, 2026

Copy link
Copy Markdown
Member

The changelog is a never-ending history of archeological layers.

The NEWS entry added by #138309 is what happened in 3.15.0a1. That's the past.

The NEWS entry for this PR is what will happen in 3.15.0b4. Please add a new NEWS entry for this change.

General info: https://devguide.python.org/getting-started/pull-request-lifecycle/#updating-news-and-what-s-new-in-python
dnicolodi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dnicolodi
dnicolodi requested a review from AA-Turner as a code owner June 24, 2026 21:35
@read-the-docs-community

read-the-docs-community Bot commented Jun 24, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33499371 | 📁 Comparing 43e66d5 against main (1d55b37)

  🔍 Preview build  

92 files changed · ± 91 modified · - 1 deleted

± Modified

  • glossary.html
  • c-api/bytes.html
  • c-api/dict.html
  • c-api/exceptions.html
  • c-api/gen.html
  • c-api/intro.html
  • c-api/list.html
  • c-api/module.html
  • c-api/sequence.html
  • c-api/threads.html
  • and 81 more...

- Deleted

  • library/asyncio-policy.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dnicolodi
Add NEWS and whatsnew entries
52b2be0
@dnicolodi
dnicolodi force-pushed the fix/win-tarfile-gettarinfo branch from 630da42 to 52b2be0 Compare June 24, 2026 21:51
@rgommers rgommers mentioned this pull request Jun 27, 2026
gh-57911: Sanitize symlink targets in tarfile on win32 #138309
Merged
@dnicolodi

dnicolodi commented Jul 5, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@hugovk gave his approval for merging this #138309 (comment) Is there anything I can help with to have this merged? @encukou
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ngoldbaum ngoldbaum added awaiting core review and removed awaiting review labels Jul 5, 2026
@ngoldbaum

ngoldbaum commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Also just in case it isn't clear, fixing this is needed for meson-python to correctly create sdists on Windows using Python 3.15.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Jul 6, 2026

Copy link
Copy Markdown
Member

Do you want to add a test as well? If not I'll add one later this week.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dnicolodi
Add test
43e66d5
@dnicolodi

dnicolodi commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

I've added a test. I am not very familiar with the organization of tests in the CPython codebase. Please let me know if it should be improved somehow.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dnicolodi

dnicolodi commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Tests / CIFuzz / python3-libraries (address) fails at the build stage, thus it is not connected to the changes in this PR.
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 9, 2026
@bedevere-bot

bedevere-bot commented Jul 9, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 43e66d5 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F151671%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 9, 2026
@encukou encukou added the needs backport to 3.15 bugs and security fixes label Jul 10, 2026
@encukou
encukou merged commit cc31641 into python:main Jul 10, 2026
149 of 154 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 10, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 10, 2026

Copy link
Copy Markdown

Thanks @dnicolodi for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jul 10, 2026

Copy link
Copy Markdown

GH-153517 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jul 10, 2026
hugovk pushed a commit that referenced this pull request Jul 17, 2026
@miss-islington @dnicolodi
[3.15] gh-151669: Normalize symlink targets in tarfile.TarFile.gettar…
fefc0b4 
…info() (GH-151671) (#153517)

Co-authored-by: Daniele Nicolodi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@dnicolodi @bonzini @ngoldbaum @hugovk @encukou @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.