GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-151678: Add tests for tkinter.Menu by serhiy-storchaka · Pull Request #151685 · python/cpython

Conversation

serhiy-storchaka commented Jun 19, 2026

Copy link

Copy Markdown

Member

Cover previously-untested Menu methods in MenuTest:

adding and inserting items of every type (command, checkbutton, radiobutton, separator, cascade), with order and type verification;
deleting single items and ranges, including cleanup of the associated Tcl command;
index resolution (end, last, label, integer, active, none);
invoking command, checkbutton and radiobutton items;
entry xposition/yposition;
post/unpost/tk_popup mapping.

It also tests per-entry configuration options (accelerator, underline, state, colors, columnbreak, hidemargin, onvalue/offvalue, value, indicatoron) and the errors raised for invalid indices, entry types, option names and option values.

Issue: Improve test coverage of tkinter #151678

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added tests

Tests in the Lib/test dir

awaiting core review labels

Jun 19, 2026

bedevere-app Bot mentioned this pull request

Jun 19, 2026

Improve test coverage of tkinter #151678

Closed

serhiy-storchaka force-pushed the test-tkinter-menu-methods branch from 7b9a320 to f9c55d8 Compare

June 19, 2026 00:08


          pythongh-151678: Add tests for tkinter.Menu

Cover previously-untested Menu methods in MenuTest: adding, inserting and
deleting items of every type, index resolution, invoking items, entry x/y
positions, and post/unpost/tk_popup mapping.

Also test per-entry configuration options and the errors raised for
invalid indices, entry types, option names and option values.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

serhiy-storchaka force-pushed the test-tkinter-menu-methods branch from f9c55d8 to 4714219 Compare

June 19, 2026 08:08

serhiy-storchaka added skip news needs backport to 3.13

only security fixes

needs backport to 3.14

bugs and security fixes

needs backport to 3.15 bugs and security fixes labels

Jun 19, 2026

serhiy-storchaka merged commit ef5c32a into python:main

Jun 19, 2026

56 checks passed

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting core review label

Jun 19, 2026

miss-islington-app Bot commented Jun 19, 2026

Copy link

Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka deleted the test-tkinter-menu-methods branch

June 19, 2026 08:59

bedevere-app Bot commented Jun 19, 2026

Copy link

Copy Markdown

GH-151709 is a backport of this pull request to the 3.15 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label

Jun 19, 2026

bedevere-app Bot commented Jun 19, 2026

Copy link

Copy Markdown

GH-151710 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Jun 19, 2026

bedevere-app Bot commented Jun 19, 2026

Copy link

Copy Markdown

GH-151711 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Jun 19, 2026

serhiy-storchaka added a commit that referenced this pull request

Jun 19, 2026


          [3.13] gh-151678: Add tests for tkinter.Menu (GH-151685) (GH-151711)

c0c9920

Cover previously-untested Menu methods in MenuTest: adding, inserting and
deleting items of every type, index resolution, invoking items, entry x/y
positions, and post/unpost/tk_popup mapping.

Also test per-entry configuration options and the errors raised for
invalid indices, entry types, option names and option values.
(cherry picked from commit ef5c32a)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>

serhiy-storchaka added a commit that referenced this pull request

Jun 19, 2026


          [3.14] gh-151678: Add tests for tkinter.Menu (GH-151685) (GH-151710)

7044daa

Cover previously-untested Menu methods in MenuTest: adding, inserting and
deleting items of every type, index resolution, invoking items, entry x/y
positions, and post/unpost/tk_popup mapping.

Also test per-entry configuration options and the errors raised for
invalid indices, entry types, option names and option values.
(cherry picked from commit ef5c32a)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>

serhiy-storchaka added a commit that referenced this pull request

Jun 19, 2026


          [3.15] gh-151678: Add tests for tkinter.Menu (GH-151685) (GH-151709)

cfe4619

Cover previously-untested Menu methods in MenuTest: adding, inserting and
deleting items of every type, index resolution, invoking items, entry x/y
positions, and post/unpost/tk_popup mapping.

Also test per-entry configuration options and the errors raised for
invalid indices, entry types, option names and option values.
(cherry picked from commit ef5c32a)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>

pyctrl pushed a commit to pyctrl/cpython that referenced this pull request

Jul 5, 2026


          pythongh-151678: Add tests for tkinter.Menu (pythonGH-151685)

de60540

Cover previously-untested Menu methods in MenuTest: adding, inserting and
deleting items of every type, index resolution, invoking items, entry x/y
positions, and post/unpost/tk_popup mapping.

Also test per-entry configuration options and the errors raised for
invalid indices, entry types, option names and option values.

Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.