GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-25810: Clarify eval() docs, it does not keywords (GH-15173) by smokephil · Pull Request #15173 · python/cpython

Conversation

@smokephil

@smokephil smokephil commented Aug 8, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

bpo-25810: Clarify eval() docs, it does not keywords (GH-15173)

https://bugs.python.org/issue25810

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@smokephil
Fix issue 25810
c0cf496
@the-knights-who-say-ni

the-knights-who-say-ni commented Aug 8, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Aug 8, 2019
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 8, 2019
aeros
aeros suggested changes Aug 8, 2019
View reviewed changes

@aeros aeros left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and thanks for the contribution!

Based on the comment from R. David Murray:

I think we are moving toward using (and documenting in the main docs) the / notation. Especially since it shows up in the inspect module as well as the docstring help.

as well as the rest of the discussion on the issue, I think it would be more appropriate to use the / notation:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/functions.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Aug 8, 2019
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Aug 9, 2019
@gpshead gpshead self-assigned this Sep 10, 2019
@gpshead gpshead added skip news needs backport to 3.7 labels Sep 10, 2019
@gpshead gpshead changed the title bpo-25810: fix documentation for eval() call bpo-25810: Clarify eval() docs, it does not keywords (GH-15173) Sep 11, 2019
@gpshead
gpshead merged commit 7a0023e into python:master Sep 11, 2019
@miss-islington

miss-islington commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Thanks @smokephil for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 11, 2019
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@smokephil @miss-islington
bpo-25810: Clarify eval() docs, it does not keywords (pythonGH-15173)
697f33f 
(cherry picked from commit 7a0023e)

Co-authored-by: smokephil <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

GH-15910 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Sep 11, 2019
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@smokephil @miss-islington
bpo-25810: Clarify eval() docs, it does not keywords (pythonGH-15173)
b6b4c02 
(cherry picked from commit 7a0023e)

Co-authored-by: smokephil <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

GH-15911 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Sep 11, 2019
miss-islington added a commit that referenced this pull request Sep 11, 2019
@miss-islington @smokephil
bpo-25810: Clarify eval() docs, it does not keywords (GH-15173)
4e914ab 
(cherry picked from commit 7a0023e)

Co-authored-by: smokephil <[email protected]>
miss-islington added a commit that referenced this pull request Sep 11, 2019
@miss-islington @smokephil
bpo-25810: Clarify eval() docs, it does not keywords (GH-15173)
d378fdb 
(cherry picked from commit 7a0023e)

Co-authored-by: smokephil <[email protected]>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@smokephil @websurfer5
bpo-25810: Clarify eval() docs, it does not keywords (pythonGH-15173)
ce66533
@wjandrea wjandrea mentioned this pull request Dec 26, 2022
eval() documentation is wrong about keyword arguments #100546
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead left review comments
+1 more reviewer
@aeros aeros aeros requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@smokephil @the-knights-who-say-ni @miss-islington @bedevere-bot @gpshead @aeros
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.