GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-151845: Fix formatfloat() return-value contract in unicode_format.c by aisk · Pull Request #151846 · python/cpython

Conversation

@aisk

@aisk aisk commented Jun 21, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As mentioned in the issue, this don't affected to callers and users, so /skip-news and don't requires a test.

  • Issue: formatfloat wrong return in unicode_format.c #151845

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aisk
Fix formatfloat() return-value contract in unicode_format.c
b54ca99
@bedevere-app bedevere-app Bot added the awaiting review label Jun 21, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 21, 2026
formatfloat wrong return in unicode_format.c #151845
Closed
@aisk aisk added the skip news label Jun 21, 2026
sobolevn
sobolevn approved these changes Jun 21, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 21, 2026
@sobolevn

sobolevn commented Jun 21, 2026

Copy link
Copy Markdown
Member

Does it need to be backported?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aisk

aisk commented Jun 21, 2026

Copy link
Copy Markdown
Member Author

This change doesn’t affect Python’s behavior because the caller already handles it. However, I think it would still be better to backport it to avoid potential future conflicts, as long as the backport is conflict-free.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn sobolevn added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jun 21, 2026
@sobolevn
sobolevn enabled auto-merge (squash) June 21, 2026 17:16
@sobolevn
sobolevn merged commit c2661e6 into python:main Jun 21, 2026
147 of 151 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

Thanks @aisk for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 21, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

Sorry, @aisk and @sobolevn, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c2661e6189ab2833bf32fa723cc427e64c026839 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned sobolevn Jun 21, 2026
@bedevere-app

bedevere-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

GH-151865 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

Sorry, @aisk and @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c2661e6189ab2833bf32fa723cc427e64c026839 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jun 21, 2026
@aisk

aisk commented Jun 21, 2026

Copy link
Copy Markdown
Member Author

Hi, since backporting this to 3.13 and 3.14 causes conflicts, I think we should just leave it as is.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aisk
aisk deleted the fix-formatfloat-return-value branch June 21, 2026 17:21
sobolevn pushed a commit that referenced this pull request Jun 21, 2026
@miss-islington @aisk
[3.15] gh-151845: Fix formatfloat() return-value contract in unicode_…
f5119a5 
…format.c (GH-151846) (#151865)

gh-151845: Fix formatfloat() return-value contract in unicode_format.c (GH-151846)

Fix formatfloat() return-value contract in unicode_format.c
(cherry picked from commit c2661e6)

Co-authored-by: AN Long <[email protected]>
@StanFromIreland

StanFromIreland commented Jun 21, 2026

Copy link
Copy Markdown
Member

@aisk feel free to remove the labels if a backport is unsuitable/not worth it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland StanFromIreland removed needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jun 21, 2026
@aisk

aisk commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

@aisk feel free to remove the labels if a backport is unsuitable/not worth it.

TIL, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pyctrl pushed a commit to pyctrl/cpython that referenced this pull request Jul 5, 2026
@aisk @pyctrl
pythongh-151845: Fix formatfloat() return-value contract in unicode_f…
3eb78f4 
…ormat.c (python#151846)

Fix formatfloat() return-value contract in unicode_format.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sobolevn sobolevn

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@aisk @sobolevn @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.