GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-151678: Add tests for tkinter.simpledialog by serhiy-storchaka · Pull Request #151856 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 21, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add tests for tkinter.simpledialog, covering SimpleDialog (the message and the buttons, the default button, go(), the <Return> and window-close bindings and the bell paths), the Dialog base class (the OK/Cancel button box and result), the query dialogs (validation, range checks, initial value, masking, and the askinteger/askfloat/askstring functions), and the default-root handling.

  • Issue: Improve test coverage of tkinter #151678

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @claude
pythongh-151678: Add tests for tkinter.simpledialog
0c97c29 
Co-Authored-By: Claude Opus 4.8 <[email protected]>
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Jun 21, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 21, 2026
Improve test coverage of tkinter #151678
Closed
@serhiy-storchaka

serhiy-storchaka commented Jun 21, 2026

Copy link
Copy Markdown
Member Author

It was split from PR #151848.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jun 21, 2026
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) June 21, 2026 16:03
@serhiy-storchaka
serhiy-storchaka merged commit f28ef85 into python:main Jun 21, 2026
59 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 21, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f28ef858f5515d200319e9675d66f8f13afa5a0d 3.15
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned serhiy-storchaka Jun 21, 2026
@bedevere-app

bedevere-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

GH-151859 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 21, 2026
@bedevere-app

bedevere-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

GH-151860 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 21, 2026
@serhiy-storchaka serhiy-storchaka added needs backport to 3.15 bugs and security fixes and removed needs backport to 3.15 bugs and security fixes labels Jun 21, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f28ef858f5515d200319e9675d66f8f13afa5a0d 3.15
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit that referenced this pull request Jun 21, 2026
@miss-islington @serhiy-storchaka @claude
[3.13] gh-151678: Add tests for tkinter.simpledialog (GH-151856) (GH-…
de8d7bb 
…151860)

(cherry picked from commit f28ef85)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Opus 4.8 <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jun 21, 2026
@miss-islington @serhiy-storchaka @claude
[3.14] gh-151678: Add tests for tkinter.simpledialog (GH-151856) (GH-…
e2d2f6e 
…151859)

(cherry picked from commit f28ef85)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Opus 4.8 <[email protected]>
@serhiy-storchaka serhiy-storchaka added needs backport to 3.15 bugs and security fixes and removed needs backport to 3.15 bugs and security fixes labels Jun 21, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the tkinter-simpledialog-tests branch June 21, 2026 18:29
@bedevere-app

bedevere-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

GH-151869 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jun 21, 2026
serhiy-storchaka added a commit that referenced this pull request Jun 21, 2026
@miss-islington @serhiy-storchaka @claude
[3.15] gh-151678: Add tests for tkinter.simpledialog (GH-151856) (GH-…
2e4dddf 
…151869)

(cherry picked from commit f28ef85)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Opus 4.8 <[email protected]>
This was referenced Jun 27, 2026
Increase test coverage for tkinter.simpledialog #144106
Closed
gh-144106 Add tests to the tkinter #144107
Closed
pyctrl pushed a commit to pyctrl/cpython that referenced this pull request Jul 5, 2026
@serhiy-storchaka @claude @pyctrl
pythongh-151678: Add tests for tkinter.simpledialog (pythonGH-151856)
b4e9d8b 
Co-authored-by: Claude Opus 4.8 <[email protected]>
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
@IvyXu420 IvyXu420 mentioned this pull request Jul 21, 2026
Tkinter: test_boundary_values_accepted fails #154357
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.